PR fix for issue #189 (GUI: have a small explanatory sentence for the rescan date) - #537
Open
TChukwuleta wants to merge 6 commits into
Open
PR fix for issue #189 (GUI: have a small explanatory sentence for the rescan date)#537TChukwuleta wants to merge 6 commits into
TChukwuleta wants to merge 6 commits into
Conversation
darosior
reviewed
May 25, 2023
darosior
left a comment
darosior
left a comment
Member
There was a problem hiding this comment.
Concept ACK. Thanks for tackling this issue. Please get rid of the merge commit and squash the fixup commit into the one where the whitespace was introduced (as per the guidelines).
Will let @edouardparis have the final call on the code.
| .push(text("Rescan date cannot be earlier than wallet creation date or pruned date (if applies)").width(Length::Fill) | ||
| .size(15) | ||
| .style(color::GREY_3)) | ||
| .push(Column::new().width(Length::Fill)).push( |
Member
There was a problem hiding this comment.
Recent Iced version introduced Space widget that help us to get ride of empty Column
Suggested change
| .push(Column::new().width(Length::Fill)).push( | |
| .push(Space::with_width(Length::Fill)).push( |
| && is_ok_and(&u32::from_str(&day.value), |&v| v > 0 && v <= 31)) | ||
| { | ||
| Row::new().push(Column::new().width(Length::Fill)).push( | ||
| Row::new().push(Column::new().width(Length::Fill)) |
Member
There was a problem hiding this comment.
Suggested change
| Row::new().push(Column::new().width(Length::Fill)) | |
| Row::new().push(Space::with_width(Length::Fill)) |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Resolved #189