Preserve styles for child components inside client:only islands during build#17292
Open
astrobot-houston wants to merge 1 commit into
Open
Preserve styles for child components inside client:only islands during build#17292astrobot-houston wants to merge 1 commit into
astrobot-houston wants to merge 1 commit into
Conversation
1 task
🦋 Changeset detectedLatest commit: a50eeb9 The changes in this PR will be included in the next version bump. This PR includes changesets to release 393 packages
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
matthewp
approved these changes
Jul 7, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #16119
Changes
client:onlyisland was silently dropped in production builds. In dev mode everything worked fine, making the bug particularly hard to spot.plugin-css.tscorrectly marks a child component's CSS for deletion (it was already bundled during SSR for another page), but theclient:onlypage never participated in SSR so it never received that CSS. ThegetParentClientOnlyswalk would add the CSS topagesToCss, but the deleted asset was already gone by the timeinlineStylesheetsPluginran.getParentClientOnlyswalk finds a CSS entry that was deleted, inline the CSS content directly intopageData.stylesfromdeletedCssAssets, bypassing the need for the asset to survive toinlineStylesheetsPlugin. Content-based deduplication prevents double-injecting styles that survived deletion normally.Testing
packages/astro/test/client-only-child-styles.test.tswith a fixture covering two scenarios: a page usingclient:only(where the child's scoped styles must be recovered fromdeletedCssAssets) and a page usingclient:loaddirectly (to confirm no regression there).Docs