Skip to content

port(MachO): Align __LINKEDIT sections #2186

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
davidlattimore merged 2 commits into from
Jul 8, 2026
+68 −1
Merged

port(MachO): Align __LINKEDIT sections #2186

Changes from 1 commit
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
8e581b9
port(MachO): align __LINKEDIT sections
joanna-jo Jul 6, 2026
c883d1b
add linker-diff test
joanna-jo Jul 8, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 6 additions & 1 deletion libwild/src/macho.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1318,7 +1318,10 @@ impl platform::Platform for MachO {
fixup_table_size += CHAINED_FIXUP_PAGE_START_SIZE
* (state.imported_symbols.len() as u64).div_ceil(MACHO_PAGE_ALIGNMENT.value());

mem_sizes.increment(part_id::CHAINED_FIXUP_TABLE, fixup_table_size);
mem_sizes.increment(
part_id::CHAINED_FIXUP_TABLE,
alignment::USIZE.align_up(fixup_table_size),
);
}

fn finalise_sizes_all<'data>(
Expand Down Expand Up @@ -1709,10 +1712,12 @@ const SECTION_DEFINITIONS: [BuiltInSectionDetails; NUM_BUILT_IN_SECTIONS] = {
};
defs[output_section_id::CHAINED_FIXUP_TABLE.as_usize()] = BuiltInSectionDetails {
kind: SectionKind::Primary(SectionName(b"DYLD_CHAINED_FIXUPS_TABLE")),
min_alignment: alignment::USIZE,
..DEFAULT_DEFS
};
defs[output_section_id::SYMTAB_GLOBAL.as_usize()] = BuiltInSectionDetails {
kind: SectionKind::Primary(SectionName(b"SYMTAB")),
min_alignment: alignment::USIZE,
..DEFAULT_DEFS
};
defs[output_section_id::CODE_SIGNATURE.as_usize()] = BuiltInSectionDetails {
Expand Down
Loading