fix(datastore/mysql): prevent SQL injection in GetTargetByScope - #255
Merged
Conversation
…SQL injection GetTargetByScope built its query with fmt.Sprintf, embedding the scope value directly into the SQL string while every other query in this file uses bind parameters. The scope originates from webhook payloads and the target registration API, so a value containing a double quote could break out of the string literal and inject SQL. Switch to a ? placeholder like GetTarget does, and add a regression test that a scope containing SQL meta characters is treated as a literal value (returning datastore.ErrNotFound rather than matching or erroring).
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
GetTargetByScopewas the only query in this file built withfmt.Sprintf, embedding thescopevalue directly into the SQL string. Every other query (e.g.GetTarget) uses bind parameters (?); this one used raw string concatenation.scopeoriginates from webhook payloads (repository / organization names) and the target registration API, so it is user-controllable. A value containing a double quote could break out of the string literal and inject SQL.Changes
GetTargetByScopeto a?placeholder, matchingGetTarget.datastore.ErrNotFound(neither matching a row nor producing a SQL error).Testing
go build ./...andgo vet ./...pass.