Repository navigation
Editorial: pass require well-formed when serializing a Document - #413
Conversation
Matching the logic intended by 59c9cd9 of not throwing for documents that cannot be serialized as well formed XML.
|
But are implementations performing the behavior specified for not throwing? Or are they just silently eating the exceptions? I would expect us to not send ill-formed XML across the network. |
This is my interpretation, but maybe I am misunderstanding something from that commit and linked issue / corresponding tests. The WPT PR web-platform-tests/wpt#5123 for 59c9cd9 seems to test this behaviour, which all engines pass (now under https://wpt.fyi/results/xhr/send-entity-body-document-bogus.htm?label=experimental&label=master&aligned). I'm going off of tests here, so there's always the possibility of misinterpreting the results where implementation behaviour is more complex than I realise (like I managed in #242 (comment) 😅) Not 100% sure what silently eating the exception means, is that not sending anything at all? |
|
Oh wow that is horrible. I forgot that we did that. |
Matching the logic intended by 59c9cd9 of not throwing for documents that cannot be serialized as well formed XML.
Found fixing a bug in ladybird where we weren't doing the "converted" part to make it scalar, and noticed we were already passing this flag which spec didn't mention.
Preview | Diff