Allow disabling return value validation to improve performance

docs/class-reference.md

@@ -72,7 +72,8 @@ static function executeQuery(
     ?array $variableValues = null,
     ?string $operationName = null,
     ?callable $fieldResolver = null,
-    ?array $validationRules = null
+    ?array $validationRules = null,
+    bool $trustResult = false
 ): GraphQL\Executor\ExecutionResult
 ```
 
@@ -100,7 +101,8 @@ static function promiseToExecute(
     ?array $variableValues = null,
     ?string $operationName = null,
     ?callable $fieldResolver = null,
-    ?array $validationRules = null
+    ?array $validationRules = null,
+    bool $trustResult = false
 ): GraphQL\Executor\Promise\Promise
 ```
 
@@ -1590,7 +1592,7 @@ Implements the "Evaluating requests" section of the GraphQL specification.
 ```php
 @phpstan-type ArgsMapper callable(array<string, mixed>, FieldDefinition, FieldNode, mixed): mixed
 @phpstan-type FieldResolver callable(mixed, array<string, mixed>, mixed, ResolveInfo): mixed
-@phpstan-type ImplementationFactory callable(PromiseAdapter, Schema, DocumentNode, mixed, mixed, array<mixed>, ?string, callable, callable): ExecutorImplementation
+@phpstan-type ImplementationFactory callable(PromiseAdapter, Schema, DocumentNode, mixed, mixed, array<mixed>, ?string, callable, ?callable, bool): ExecutorImplementation
 ```
 
 @see \GraphQL\Tests\Executor\ExecutorTest
@@ -1621,7 +1623,8 @@ static function execute(
     $contextValue = null,
     ?array $variableValues = null,
     ?string $operationName = null,
-    ?callable $fieldResolver = null
+    ?callable $fieldResolver = null,
+    bool $trustResult = false
 ): GraphQL\Executor\ExecutionResult
 ```
 
@@ -1650,7 +1653,8 @@ static function promiseToExecute(
     ?array $variableValues = null,
     ?string $operationName = null,
     ?callable $fieldResolver = null,
-    ?callable $argsMapper = null
+    ?callable $argsMapper = null,
+    bool $trustResult = false
 ): GraphQL\Executor\Promise\Promise
 ```
 

src/Executor/ExecutionContext.php

@@ -54,6 +54,8 @@ class ExecutionContext
 
     public PromiseAdapter $promiseAdapter;
 
+    public bool $trustResult;
+
     /**
      * @param array<string, FragmentDefinitionNode> $fragments
      * @param mixed $rootValue
@@ -73,7 +75,8 @@ public function __construct(
         array $errors,
         callable $fieldResolver,
         callable $argsMapper,
-        PromiseAdapter $promiseAdapter
+        PromiseAdapter $promiseAdapter,
+        bool $trustResult = false
     ) {
         $this->schema = $schema;
         $this->fragments = $fragments;
@@ -85,6 +88,7 @@ public function __construct(
         $this->fieldResolver = $fieldResolver;
         $this->argsMapper = $argsMapper;
         $this->promiseAdapter = $promiseAdapter;
+        $this->trustResult = $trustResult;
     }
 
     public function addError(Error $error): void

src/Executor/Executor.php

@@ -18,7 +18,7 @@
  *
  * @phpstan-type ArgsMapper callable(array<string, mixed>, FieldDefinition, FieldNode, mixed): mixed
  * @phpstan-type FieldResolver callable(mixed, array<string, mixed>, mixed, ResolveInfo): mixed
- * @phpstan-type ImplementationFactory callable(PromiseAdapter, Schema, DocumentNode, mixed, mixed, array<mixed>, ?string, callable, callable): ExecutorImplementation
+ * @phpstan-type ImplementationFactory callable(PromiseAdapter, Schema, DocumentNode, mixed, mixed, array<mixed>, ?string, callable, ?callable, bool): ExecutorImplementation
  *
  * @see \GraphQL\Tests\Executor\ExecutorTest
  */
@@ -125,7 +125,8 @@ public static function execute(
         $contextValue = null,
         ?array $variableValues = null,
         ?string $operationName = null,
-        ?callable $fieldResolver = null
+        ?callable $fieldResolver = null,
+        bool $trustResult = false
     ): ExecutionResult {
         $promiseAdapter = new SyncPromiseAdapter();
 
@@ -137,7 +138,9 @@ public static function execute(
             $contextValue,
             $variableValues,
             $operationName,
-            $fieldResolver
+            $fieldResolver,
+            null,
+            $trustResult
         );
 
         return $promiseAdapter->wait($result);
@@ -167,7 +170,8 @@ public static function promiseToExecute(
         ?array $variableValues = null,
         ?string $operationName = null,
         ?callable $fieldResolver = null,
-        ?callable $argsMapper = null
+        ?callable $argsMapper = null,
+        bool $trustResult = false
     ): Promise {
         $executor = (self::$implementationFactory)(
             $promiseAdapter,
@@ -179,6 +183,7 @@ public static function promiseToExecute(
             $operationName,
             $fieldResolver ?? self::$defaultFieldResolver,
             $argsMapper ?? self::$defaultArgsMapper,
+            $trustResult,
         );
 
         return $executor->doExecute();

src/Executor/ReferenceExecutor.php

@@ -105,7 +105,8 @@ public static function create(
         array $variableValues,
         ?string $operationName,
         callable $fieldResolver,
-        ?callable $argsMapper = null // TODO make non-optional in next major release
+        ?callable $argsMapper = null, // TODO make non-optional in next major release
+        bool $trustResult = false
     ): ExecutorImplementation {
         $exeContext = static::buildExecutionContext(
             $schema,
@@ -117,6 +118,7 @@ public static function create(
             $fieldResolver,
             $argsMapper ?? Executor::getDefaultArgsMapper(),
             $promiseAdapter,
+            $trustResult
         );
 
         if (is_array($exeContext)) {
@@ -152,7 +154,8 @@ protected static function buildExecutionContext(
         ?string $operationName,
         callable $fieldResolver,
         callable $argsMapper,
-        PromiseAdapter $promiseAdapter
+        PromiseAdapter $promiseAdapter,
+        bool $trustResult = false
     ) {
         /** @var list<Error> $errors */
         $errors = [];
@@ -229,7 +232,8 @@ protected static function buildExecutionContext(
             $errors,
             $fieldResolver,
             $argsMapper,
-            $promiseAdapter
+            $promiseAdapter,
+            $trustResult
         );
     }
 
@@ -884,7 +888,7 @@ protected function completeValue(
                 $result,
                 $contextValue
             );
-            if ($completed === null) {
+            if ($completed === null && ! $this->exeContext->trustResult) {
                 throw new InvariantViolation("Cannot return null for non-nullable field \"{$info->parentType}.{$info->fieldName}\".");
             }
 
@@ -897,7 +901,7 @@ protected function completeValue(
 
         // If field type is List, complete each item in the list with the inner type
         if ($returnType instanceof ListOfType) {
-            if (! is_iterable($result)) {
+            if (! $this->exeContext->trustResult && ! is_iterable($result)) {
                 $resultType = gettype($result);
 
                 throw new InvariantViolation("Expected field {$info->parentType}.{$info->fieldName} to return iterable, but got: {$resultType}.");
@@ -1053,6 +1057,10 @@ protected function completeListValue(
      */
     protected function completeLeafValue(LeafType $returnType, $result)
     {
+        if ($this->exeContext->trustResult) {
+            return $result;
+        }
+
         try {
             return $returnType->serialize($result);
         } catch (\Throwable $error) {
@@ -1225,36 +1233,38 @@ protected function completeObjectValue(
         // If there is an isTypeOf predicate function, call it with the
         // current result. If isTypeOf returns false, then raise an error rather
         // than continuing execution.
-        $isTypeOf = $returnType->isTypeOf($result, $contextValue, $info);
-        if ($isTypeOf !== null) {
-            $promise = $this->getPromise($isTypeOf);
-            if ($promise !== null) {
-                return $promise->then(function ($isTypeOfResult) use (
-                    $contextValue,
-                    $returnType,
-                    $fieldNodes,
-                    $path,
-                    $unaliasedPath,
-                    $result
-                ) {
-                    if (! $isTypeOfResult) {
-                        throw $this->invalidReturnTypeError($returnType, $result, $fieldNodes);
-                    }
-
-                    return $this->collectAndExecuteSubfields(
+        if (! $this->exeContext->trustResult) {
+            $isTypeOf = $returnType->isTypeOf($result, $contextValue, $info);
+            if ($isTypeOf !== null) {
+                $promise = $this->getPromise($isTypeOf);
+                if ($promise !== null) {
+                    return $promise->then(function ($isTypeOfResult) use (
+                        $contextValue,
                         $returnType,
                         $fieldNodes,
                         $path,
                         $unaliasedPath,
-                        $result,
-                        $contextValue
-                    );
-                });
-            }
+                        $result
+                    ) {
+                        if (! $isTypeOfResult) {
+                            throw $this->invalidReturnTypeError($returnType, $result, $fieldNodes);
+                        }
 
-            assert(is_bool($isTypeOf), 'Promise would return early');
-            if (! $isTypeOf) {
-                throw $this->invalidReturnTypeError($returnType, $result, $fieldNodes);
+                        return $this->collectAndExecuteSubfields(
+                            $returnType,
+                            $fieldNodes,
+                            $path,
+                            $unaliasedPath,
+                            $result,
+                            $contextValue
+                        );
+                    });
+                }
+
+                assert(is_bool($isTypeOf), 'Promise would return early');
+                if (! $isTypeOf) {
+                    throw $this->invalidReturnTypeError($returnType, $result, $fieldNodes);
+                }
             }
         }
 

src/GraphQL.php

@@ -90,7 +90,8 @@ public static function executeQuery(
         ?array $variableValues = null,
         ?string $operationName = null,
         ?callable $fieldResolver = null,
-        ?array $validationRules = null
+        ?array $validationRules = null,
+        bool $trustResult = false
     ): ExecutionResult {
         $promiseAdapter = new SyncPromiseAdapter();
 
@@ -103,7 +104,8 @@ public static function executeQuery(
             $variableValues,
             $operationName,
             $fieldResolver,
-            $validationRules
+            $validationRules,
+            $trustResult
         );
 
         return $promiseAdapter->wait($promise);
@@ -132,7 +134,8 @@ public static function promiseToExecute(
         ?array $variableValues = null,
         ?string $operationName = null,
         ?callable $fieldResolver = null,
-        ?array $validationRules = null
+        ?array $validationRules = null,
+        bool $trustResult = false
     ): Promise {
         try {
             $documentNode = $source instanceof DocumentNode
@@ -168,7 +171,9 @@ public static function promiseToExecute(
                 $context,
                 $variableValues,
                 $operationName,
-                $fieldResolver
+                $fieldResolver,
+                null,
+                $trustResult
             );
         } catch (Error $e) {
             return $promiseAdapter->createFulfilled(

src/Server/Helper.php

@@ -299,7 +299,8 @@ protected function promiseToExecuteOperation(
                 $op->variables,
                 $op->operation,
                 $config->getFieldResolver(),
-                $this->resolveValidationRules($config, $op, $doc, $operationType)
+                $this->resolveValidationRules($config, $op, $doc, $operationType),
+                $config->getTrustResult()
             );
         } catch (RequestError $e) {
             $result = $promiseAdapter->createFulfilled(

src/Server/ServerConfig.php

@@ -85,6 +85,9 @@ public static function create(array $config = []): self
                 case 'promiseAdapter':
                     $instance->setPromiseAdapter($value);
                     break;
+                case 'trustResult':
+                    $instance->setTrustResult($value);
+                    break;
                 default:
                     throw new InvariantViolation("Unknown server config option: {$key}");
             }
@@ -135,6 +138,8 @@ public static function create(array $config = []): self
 
     private ?PromiseAdapter $promiseAdapter = null;
 
+    private bool $trustResult = false;
+
     /**
      * @var callable|null
      *
@@ -276,6 +281,14 @@ public function setPromiseAdapter(PromiseAdapter $promiseAdapter): self
         return $this;
     }
 
+    /** @api */
+    public function setTrustResult(bool $trustResult): self
+    {
+        $this->trustResult = $trustResult;
+
+        return $this;
+    }
+
     /** @return mixed|callable */
     public function getContext()
     {
@@ -344,4 +357,9 @@ public function getQueryBatching(): bool
     {
         return $this->queryBatching;
     }
+
+    public function getTrustResult(): bool
+    {
+        return $this->trustResult;
+    }
 }