WebMCP: Reject invalid origins with "NotSupportedError" - #61564
Merged
Conversation
chromium-wpt-export-bot
force-pushed
the
chromium-export-cl-8155899
branch
from
July 28, 2026 01:54
4b040f3 to
02a107e
Compare
chromium-wpt-export-bot
marked this pull request as ready for review
July 28, 2026 02:15
See https://crrev.com/c/8121241/comment/a263bec5_46b078a4/ and webmachinelearning/webmcp#226 (comment). With both Mason *and* François in agreement about this, we should migrate from DataError => NotSupportedError. R=masonf Bug: 489045948,536063275 Change-Id: I9e5fc78b082de179c016f8a16dc052744ee28513 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/8155899 Reviewed-by: Mason Freed <masonf@chromium.org> Commit-Queue: Dominic Farolino <dom@chromium.org> Cr-Commit-Position: refs/heads/main@{#1669154}
chromium-wpt-export-bot
force-pushed
the
chromium-export-cl-8155899
branch
from
July 28, 2026 02:15
02a107e to
4af2bab
Compare
wpt-pr-bot
approved these changes
Jul 28, 2026
wpt-pr-bot
left a comment
Collaborator
There was a problem hiding this comment.
The review process for this patch is being conducted in the Chromium project.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
See https://crrev.com/c/8121241/comment/a263bec5_46b078a4/ and
webmachinelearning/webmcp#226 (comment).
With both Mason and François in agreement about this, we should
migrate from DataError => NotSupportedError.
R=masonf
Bug: 489045948,536063275
Change-Id: I9e5fc78b082de179c016f8a16dc052744ee28513
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/8155899
Reviewed-by: Mason Freed <masonf@chromium.org>
Commit-Queue: Dominic Farolino <dom@chromium.org>
Cr-Commit-Position: refs/heads/main@{#1669154}