Repository navigation
Upgrade Node.js to 22.23.4 - #1755
Open
yenienserrano wants to merge 1 commit into
Open
yenienserrano wants to merge 1 commit into
yenienserrano wants to merge 1 commit into
Conversation
Node.js 22.22.0 is affected by the October 2026 Node.js security release. Bump .nvmrc, .node-version and the hardcoded NODE_VERSION defaults in dev-tools to 22.23.4. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> Signed-off-by: Ian Yenien Serrano <63758389+yenienserrano@users.noreply.github.com>
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Node.js
22.22.0is affected by the Node.js security release of October 21, 2026 (CVE-2026-111497, CVE-2026-106069 and CVE-2026-105482, High severity).22.23.4is the fixed release in the same 22.x LTS line. The upstream OpenSearch Dashboards 3.6 branch still uses22.22.0, so the bump is applied here.Closes #1752
Proposed Changes
.nvmrcand.node-versionto22.23.4. The package build (src/dev/build/lib/config.ts) reads.nvmrcto download the bundled Node.js binary, and the CI workflows read it throughnode-version-file, so both follow automatically.NODE_VERSIONdefaults and examples indev-tools/:build-dev-image/wzd.dockerfile,build-dev-image/build-multiarch.sh,build-dev-image/README.mdbuild-packages/base-packages-to-base/base-packages.Dockerfile,run-docker-compose.sh,README.mdCHANGELOG.mdentry.The
engines.noderange inpackage.json(>=14.20.1 <23) already accepts22.23.4, so it is unchanged.This matches the upstream bump to
22.23.4(opensearch-project#13037). Upstream opensearch-project#12270, which reduces.nvmrcto the major version (22) and moves the exact version to.node-version, is not adopted here. The package build (src/dev/build/lib/config.ts) and the dev image workflow still read the exact version from.nvmrc, andsrc/dev/node_versions_must_match.test.tsrequires both files to match.Results and Evidence
Run on the host with the version from
.nvmrc(nvm use):Package build
Build run 43047016873 (
system=both,architecture=amd64,revision=0,reference_plugins=5.0.0) finished with every job insuccess, includingGenerate packages,Test packageandUpload packagefor both DEB and RPM.The dashboard build downloads and bundles Node.js
22.23.4, with the checksum verified:Every build job, including all plugin builds and both package generation jobs, ran on
node: v22.23.4.Generated packages:
wazuh-dashboard_5.0.0-0_amd64_8c9250e3-f914589-97c31cd-2f39968-d5f3909-7d315e8-de53dc9.debwazuh-dashboard_5.0.0-0_x86_64_8c9250e3-f914589-97c31cd-2f39968-d5f3909-7d315e8-de53dc9.rpmNode.js bundled in each package, extracted and run in a
linux/amd64container:Artifacts Affected
NODE_VERSIONdefault)Configuration Changes
None.
Documentation Updates
dev-tools/build-dev-image/README.mddev-tools/build-packages/base-packages-to-base/README.mdTests Introduced
None. Version bump only; existing unit tests run with Node.js
22.23.4.Review Checklist
no-changelog)node --versionreturnsv22.23.4🤖 Generated with Claude Code