[CODE-1832] Show the last response's duration and credits in the TUI indicator slot#13501
[CODE-1832] Show the last response's duration and credits in the TUI indicator slot#13501ianhodge wants to merge 1 commit into
Conversation
|
I'm starting a first review of this pull request. You can view the conversation on Warp. I completed the review and no human review was requested for this pull request. Comment Powered by Oz |
There was a problem hiding this comment.
Overview
This PR adds a completed-response summary row to the TUI indicator slot, showing the resting spinner, wall-to-wall duration, and optional credits for the last response. I did not find actionable correctness, security, or spec-drift issues in the annotated diff.
Concerns
- This is a user-facing TUI change, but the attached PR description does not include actual screenshots or a screen recording. It only says E2E verification with recording is queued. For this user-facing change, please include screenshots or a screen recording demonstrating it working end to end.
Verdict
Found: 0 critical, 1 important, 0 suggestions
Request changes
Comment /oz-review on this pull request to retrigger a review (up to 3 times on the same pull request).
Powered by Oz
cfc644c to
781b64e
Compare
0e26397 to
138b9bb
Compare
138b9bb to
f014143
Compare
781b64e to
827a488
Compare
| } | ||
|
|
||
| #[test] | ||
| fn response_summary_shows_duration_and_credits_without_repaints() { |
There was a problem hiding this comment.
very much a nit -- but I don't think these two unit tests are that useful
827a488 to
422b34e
Compare
f014143 to
22b00b9
Compare
422b34e to
0ad5c17
Compare
22b00b9 to
4761080
Compare
0ad5c17 to
e0a047f
Compare
4761080 to
50b8746
Compare
e0a047f to
925e16f
Compare
cfd9d4a to
1d27a5d
Compare
78b1e78 to
6d727fd
Compare
1d27a5d to
d39b7a1
Compare
…ot (CODE-1832) Per the Figma mocks, usage stays hidden while streaming (the Warping row is unchanged); once the response completes, the indicator's slot rests on a static summary row: the resting glyph, the wall-to-wall duration, and the credits the response spent — the GUI footer's "Credits spent (last response)" number formatted with format_credits. Consumes the existing block-level conversation accessors; no app-side changes. Co-Authored-By: Oz <oz-agent@warp.dev>
d39b7a1 to
3194a54
Compare
Description
Stacked on #13492. Shows the last response's duration and credits in the TUI's indicator slot (CODE-1832, parent CODE-1828; Figma).
What
⋮ Warping (Ns)row (TUI warping indicator #13442) is unchanged — the mocks keep usage hidden during streaming (the usage element in frame323:17216isopacity: 0).∷ 5s • 0.5 credits— resting spinner glyph, wall-to-wall duration, and the credits the response spent (the mock's∷ 1s • …completed state, with credits instead of tokens per the CODE-1831 direction).How
render_response_summaryjoins the indicator family inwarping_indicator.rs; muted styling per the mock, credits via the GUI'sformat_credits.TuiTerminalSessionView::renderfrom existing block-level accessors —wall_to_wall_response_time_since_last_query()andcredits_spent_for_last_block()(the GUI footer's "Credits spent (last response)"). No app-side changes.ConversationUsageMetadataUpdatedsubscription plus the status-change repaint that already removes the Warping row.specs/CODE-1828/TECH.md).Linked Issue
Internal Linear-driven work — CODE-1832; no GitHub issue.
ready-to-specorready-to-implement. (N/A — Linear-tracked internal task)Testing
Unit tests in
warping_indicator_tests.rs: the summary row renders∷ 5s • 2.5 creditswith no repaint scheduling; the credits segment is omitted forNone/zero.cargo nextest run -p warp_tui(97/97), clippy-D warnings,./script/formatall clean.E2E verified on a live PTY run against staging (two full prompt/response cycles). Rendered-screen captures confirmed:
⋮ Warping (0s)with no credits segment, for both prompts.∷ 1s • 2.4 creditsafter the first response and∷ 1s • 1 creditafter the second (singular form correct).auto (genius) ~/warp • 2.4 creditsclick-toggles to• $0.04and back; footer stays hidden until usage is first reported.I have manually tested my changes locally with
./script/run-tuiScreenshots / Videos
Live PTY verification screen captures (streaming, completed summary rows for both responses, and the footer credits/$ toggle both directions) recorded from the run described in Testing above.
Agent Mode
Warp conversation
Co-Authored-By: Oz oz-agent@warp.dev