Conversation
10.996 was spelled as 10 rubles and 100 kopecks.
|
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.



Summary
Rounding a ruble amount to two decimals could leave the minor part at 100 kopecks.
MoneySpeller::spell(10.996, RUB, short)returned10 рублей 100 копеек. It now returns11 рублей. Amounts that already land on a real kopeck, such as123.45, are unchanged.Test plan
tests/Russian/MoneySpellerTest.phpfailed this case: expected11 рублей, actual10 рублей 100 копеекMade with Cursor