Skip to content

Add satellite splash sound and fix asteroid crash sounds - #9

Open
wannerdev wants to merge 1 commit into
mainfrom
feature/sun-splash-sound
Open

Add satellite splash sound and fix asteroid crash sounds#9
wannerdev wants to merge 1 commit into
mainfrom
feature/sun-splash-sound

Conversation

@wannerdev

Copy link
Copy Markdown
Owner

Description

Enhances audio feedback by adding distinct sounds for different collision types and fixing asteroid crash sound behavior.

Changes

  • Added Satellite and Asteroid imports for entity type checking
  • Satellites crashing into sun now play warning sound (splash effect)
  • Asteroids crashing into sun play no sound (silent disappearance)
  • Asteroid-satellite collisions now properly play crash sound
  • Fixed asteroid swarm parent entity being skipped for sound
  • Improved collision sound logic with entity type detection
  • Using warning_sound as placeholder for splash effect

Sound Behavior

Before:

  • All collisions except sun collisions: crash sound
  • Sun collisions: muted (no sound)
  • Asteroid swarm parent: skipped

After:

  • Satellite → Sun: Warning sound (splash effect)
  • Asteroid → Sun: No sound (silent)
  • Satellite ↔ Satellite: Crash sound
  • Satellite ↔ Asteroid: Crash sound
  • Asteroid swarm parent: Properly skipped

Audio Assets

  • Currently using warning_sound as placeholder for splash effect
  • Can be replaced with custom splash sound asset later
  • Crash sound properly plays for non-sun collisions

Benefits

  • Better audio feedback for different collision types
  • Satellites entering sun have distinct sound
  • Asteroids silently disappear into sun (less audio clutter)
  • Improved player awareness of collision types
  • More polished audio experience

Testing

  • Launch satellite into sun → Verify warning/splash sound plays
  • Launch asteroid into sun → Verify no sound plays
  • Crash satellites together → Verify crash sound plays
  • Crash satellite into asteroid → Verify crash sound plays
  • Check that sounds don't overlap or cause audio issues

Related Issue

Fixes: Sound Effects - Add satellite splash into sun sound and fix asteroid crash sound

- Added Satellite and Asteroid imports for entity type checking
- Satellites crashing into sun now play warning sound (splash effect)
- Asteroids crashing into sun play no sound (silent disappearance)
- Asteroid-satellite collisions now properly play crash sound
- Fixed asteroid swarm parent entity being skipped
- Improved collision sound logic with entity type detection
- Using warning_sound as placeholder for splash effect
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant