Add satellite splash sound and fix asteroid crash sounds - #9
Open
wannerdev wants to merge 1 commit into
Open
Conversation
- Added Satellite and Asteroid imports for entity type checking - Satellites crashing into sun now play warning sound (splash effect) - Asteroids crashing into sun play no sound (silent disappearance) - Asteroid-satellite collisions now properly play crash sound - Fixed asteroid swarm parent entity being skipped - Improved collision sound logic with entity type detection - Using warning_sound as placeholder for splash effect
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Enhances audio feedback by adding distinct sounds for different collision types and fixing asteroid crash sound behavior.
Changes
SatelliteandAsteroidimports for entity type checkingwarning_soundas placeholder for splash effectSound Behavior
Before:
After:
Audio Assets
warning_soundas placeholder for splash effectBenefits
Testing
Related Issue
Fixes: Sound Effects - Add satellite splash into sun sound and fix asteroid crash sound