Add Japanese radio comms on hover select - #21
Open
wannerdev wants to merge 1 commit into
Open
Conversation
- Added RadioCommsPlaying component to track radio sound - Implemented play_radio_comms_on_hover system - Plays sound when satellite is selected (NavigationInstruments added) - Uses Changed<NavigationInstruments> to detect selection events - Stops previous radio comms before playing new one - Using warning_sound as placeholder for Japanese radio comms - TODO: Replace with actual Japanese radio comms audio file - Integrated into SoundPlugin update systems
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Adds audio feedback that plays Japanese radio communications when hovering over and selecting satellites, enhancing the space theme and providing audio confirmation of selection.
Changes
RadioCommsPlayingcomponent to track radio comms soundplay_radio_comms_on_hoversystemChanged<NavigationInstruments>to detect selection eventsSatellite,NavigationInstrumentsSoundPluginupdate systemswarning_soundas placeholder (needs replacement with actual Japanese audio)Audio Behavior
Implementation Details
Changed<NavigationInstruments>filterPlaybackSettings::DESPAWNfor automatic cleanupPlaceholder Audio
warning_sound(beepx3.wav) as placeholderassets/sounds/directorySolarSystemAssetsinsrc/sun_system/mod.rsHow to Replace Placeholder
assets/sounds/japanese_comms.wavSolarSystemAssets:play_radio_comms_on_hover:Benefits
Technical Details
Testing
Future Enhancement
Related Issue
Fixes: Twitch Feedback - On hover select, some Japanese radio comms talk in the background