fix(website): repair French MDX corrupted by translation sync, unblocking the v2 site build#5744
Merged
Merged
Conversation
…king the v2 site build The 2026-04-06 'docs: sync translations' commit (8224d70) introduced two MDX syntax errors in the French docs: - reference/options.mdx: a footnote gained literal '{.footnote-backref}' attribute syntax, which MDX parses as a JS expression (acorn error) - guides/sveltekit.mdx: a code span lost its backticks, leaving a bare '<page>' that MDX treats as an unclosed JSX tag Every Cloudflare Pages build of wails.io has failed since, so the live site has been frozen at its 2026-04-06 content (stale sponsors.svg, missing contributors.svg, three months of docs changes unpublished). Verified: 'npm run build' in website/ now completes for all locales.
Contributor
|
Caution Review failedThe pull request is closed. ℹ️ Recent review info⚙️ Run configurationConfiguration used: Path: .coderabbit.yaml Review profile: CHILL Plan: Pro Run ID: 📒 Files selected for processing (2)
WalkthroughMinor Markdown formatting corrections were made to two French documentation files: adjusting inline code escaping in a SvelteKit guide bullet and removing stray footnote backreference HTML in the options reference page. No textual content changed. ChangesFrench documentation formatting fixes
Estimated code review effort: 1 (Trivial) | ~2 minutes Suggested labels: Poem
✨ Finishing Touches🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
Member
Author
|
So sick of MDX NGL |
leaanthony
marked this pull request as ready for review
July 4, 2026 10:53
leaanthony
pushed a commit
that referenced
this pull request
Jul 4, 2026
…French MDX corrupted by translation sync, unblocking the v2 site build
Contributor
There was a problem hiding this comment.
Pull request overview
This PR repairs MDX syntax corruption in the French v2 website docs introduced by a translation sync, unblocking Docusaurus/Cloudflare Pages builds for the v2 site.
Changes:
- Removes invalid MDX attribute syntax appended to a French footnote definition in
reference/options.mdx. - Restores correct inline-code backticks around a
window.location.hrefexample inguides/sveltekit.mdxto avoid MDX/JSX parsing errors.
Reviewed changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated 2 comments.
| File | Description |
|---|---|
| website/i18n/fr/docusaurus-plugin-content-docs/current/reference/options.mdx | Removes the corrupted footnote backref attribute fragment that breaks MDX parsing. |
| website/i18n/fr/docusaurus-plugin-content-docs/current/guides/sveltekit.mdx | Fixes the corrupted inline code span so MDX no longer interprets <page> as JSX. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Comment on lines
963
to
+964
| [^1]: Cela nécessite la prise en charge de WebKit2GTK 2.36+ et votre application doit être construite avec la balise de compilation `webkit2_36` pour activer le support de cette fonctionnalité. Cela augmente aussi la version minnimale de WebKit2GTK à 2.36 pour votre application. | ||
| [^2]: Cela nécessite la prise en charge de WebKit2GTK 2.40+ et votre application doit être construite avec la balise de compilation `webkit2_40` pour activer le support de cette fonctionnalité. Cela augmente aussi la version minnimale de WebKit2GTK à 2.40 pour votre application. [ [ ↩](#fnref2:2){.footnote-backref} ↩](#fnref:2){.footnote-backref} | ||
| [^2]: Cela nécessite la prise en charge de WebKit2GTK 2.40+ et votre application doit être construite avec la balise de compilation `webkit2_40` pour activer le support de cette fonctionnalité. Cela augmente aussi la version minnimale de WebKit2GTK à 2.40 pour votre application. |
Comment on lines
+111
to
112
| - Tout ce qui provoque la navigation de page complète : `window.location.href = '/<some>/<page>'` ou le menu contextuel se recharge lorsque vous utilisez wails dev. Cela signifie que vous pouvez finir par perdre la possibilité d'appeler n'importe quel runtime cassant l'application. Il y a deux façons de contourner ce problème. | ||
| - Utilisez `import { goto } de '$app/navigation'` puis appelez `goto('/<some>/<page>')` dans votre +page.svelte. Cela empêchera la navigation de la page complète. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The story
wails.io has not deployed since 2026-04-06. Every Cloudflare Pages build of the v2 site (project
wails) since then has failed — the live site is a frozen snapshot of the 2026-04-06 content. That's why https://wails.io/img/sponsors.svg still serves the old sponsorskit image andcontributors.svg404s, which in turn is why the credits pages (including https://v3.wails.io/credits/, which hotlinks those images) show old graphics even though #5719 and #5724 are merged.Root cause
The
docs: sync translationscommit 8224d70 (2026-04-06) introduced two MDX syntax errors into the French docs:reference/options.mdx— a footnote gained literal{.footnote-backref}attribute syntax; MDX parses{...}as a JS expression and acorn fails ("Could not parse expression with acorn").guides/sveltekit.mdx— a code span lost its backticks (opening one escaped as\``, closing one dropped), leaving a barethat MDX treats as an unclosed JSX tag ("Expected a closing tag for`").Docusaurus aborts on the first error, so only one showed per build.
Fix
Two one-line repairs restoring the structure of the English source. Verified locally:
npm run buildinwebsite/(Node 22) now completes successfully for all locales and versions.Notes
wailssucceed and republish three months of pending content, including the newsponsors.svg/contributors.svg.[skip ci], which Cloudflare also honours — image-only refreshes will ride along with the next regular commit to master, same as before.npm run build(or at least MDX-compiles) on PRs/pushes touchingwebsite/, so a bad translation sync can't silently freeze the site again; and checking whether the Crowdin source still contains the corrupt strings, in which case the next sync could reintroduce them.Summary by CodeRabbit