fix(compile): resolve pickle error and merge skill_name changes - #3738
Open
fujiajie666 wants to merge 1 commit into
Open
fix(compile): resolve pickle error and merge skill_name changes#3738fujiajie666 wants to merge 1 commit into
fujiajie666 wants to merge 1 commit into
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Fixes the OpenViking
ov compilefailure[INTERNAL] cannot pickle '_thread.lock' object,and merges the upstream
skill_nameprompt changes from commit 6aab476. Also relaxes thecompile renderer's reserved-filename set so Skill-defined outputs like
index.mdare nolonger rejected.
Human Involvement
Related Issue
Type of Change
Changes Made
cannot pickle '_thread.lock' objectinBotCompileService: replace the fullmodel_copy(deep=True)(which deep-copied aVLMConfigholding an unpicklablethreading.Lock) with a shallow copy that only resetsskillsand deep-copies thesandboxsubtree.skill_nameparameter through_build_promptsand add askill_read_ruleinstructing the agent to read Skill package files via
read_fileunderskills/<skill-name>/instead ofopenviking_*tools (merged from upstream 6aab476).agent/tools/compile.pyand a design-doc note indocs/design/ov-compile-design.md._RESERVED_FILENAMESincompile/renderer.pyto only.abstract.md/.overview.md, so Skill-produced files such asindex.mdare allowed.Testing
bot/tests/test_compile.py— 83 passed locally (pytest bot/tests/test_compile.py),including new tests for skill-workspace read redirection and the
skill_nameprompt wiring.Checklist
Additional Notes
Root cause of the pickle error: a
threading.Lockprivate attribute was added toVLMConfig(_media_semaphore_lock) on 8-3, which made anymodel_copy(deep=True)of thecompile task config fail. The chat path is unaffected because it never deep-copies the
config; this change is compile-only.