fix(semantic): preserve abstracts after list markers - #3718
Draft
ehz0ah wants to merge 1 commit into
Draft
Conversation
Ignore list markers, decimals, and abbreviations when selecting truncation boundaries so generated abstracts cannot collapse to fragments such as 1.
ehz0ah
force-pushed
the
fix/abstract-list-marker-truncation
branch
from
August 4, 2026 02:44
f966aea to
08b6e43
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Fix generated abstract truncation so numbered-list markers such as
1.are not mistaken for sentence endings.A long overview introduction beginning with OpenViking's own numbered format could previously truncate
.abstract.mdto exactly1., silently completing semantic processing with an unusable summary. The new boundary scanner ignores numbered/lettered list markers, decimals, and common abbreviations while preserving CJK punctuation, paragraph boundaries, Markdown structure, tiny limits, and the existing long-first-sentence behavior.Human Involvement
Related Issue
Fixes #3709
Type of Change
Changes Made
_normalize_overview_generationand the default 256-character abstract limit.Testing
The complete semantic-processor glob has one unrelated existing failure in the move/vector-store test caused by an unchanged path-lock mock.
Checklist
Screenshots (if applicable)
Not applicable.
Additional Notes
This PR intentionally does not change
abstract_max_charsoroverview_max_charsdefaults.