feat/openviking_assets_support_git_commit_id - #3703
Draft
zihengli-bytedance wants to merge 2 commits into
Draft
Conversation
zihengli-bytedance
force-pushed
the
feat/openviking_assets_support_git_commit_id
branch
from
August 4, 2026 14:03
3dc95fa to
c4f707c
Compare
zihengli-bytedance
force-pushed
the
feat/openviking_assets_support_git_commit_id
branch
from
August 4, 2026 14:10
c4f707c to
b0caba2
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
为
ov add-resource --manifest的 Git 资源新增按 commit 精确导入能力。Manifest 现在支持通过params.commit指定完整的 40 位 commit SHA,并将其贯穿 Resolver、Preflight、CLI 参数构造和资源导入链路,从而支持可复现的固定版本导入。Human Involvement
Related Issue
N/A
Type of Change
Changes Made
commit字段,仅接受完整的 40 位十六进制 SHA,并规范化为小写。branch与commit互斥校验,将 commit 纳入git_ref、asset_id、Preflight 请求以及 CLIadd_resource参数。HEAD检查仓库访问权限;精确 commit 的可用性由导入阶段的 fetch/checkout 验证。Testing
Test results:
33 passed13 passedruff check: passedcargo fmt --check: passedgit diff --check: passedChecklist
Screenshots (if applicable)
N/A
Additional Notes
commit必须使用完整的 40 位 SHA;缩写 SHA 会在 Manifest 解析阶段被拒绝。branch与commit不能同时设置。git ls-remote无法在不拉取仓库数据的情况下可靠验证任意历史 commit,因此 Preflight 只验证 SHA 格式和仓库访问权限,精确 commit 在实际导入时验证。watch_interval,但 Watch 会重复处理相同版本,通常建议设置为0。