Repository navigation
Fix expected "too short" validation msg for changes in upcoming k8s v1.38.0 - #3365
Merged
Merged
Conversation
Signed-off-by: Ryan Richard <richardry@vmware.com>
✅ Deploy Preview for pinniped-dev canceled.
|
cfryanr
enabled auto-merge
October 26, 2026 18:36
Closed
v0lkan
reviewed
Oct 26, 2026
| }, | ||
| wantErr: `JWTAuthenticator.authentication.concierge.` + env.APIGroupSuffix + ` "` + objectMeta.Name + `" is invalid: ` + | ||
| `spec.audience: Invalid value: "": spec.audience in body should be at least 1 chars long`, | ||
| wantKube38OrNewerErr: `JWTAuthenticator.authentication.concierge.` + env.APIGroupSuffix + ` "` + objectMeta.Name + `" is invalid: ` + |
Member
There was a problem hiding this comment.
not a merge-blocker, just nit/observation:
I would have preferred a string formatter, interpolator instead.
but since this is a test, that's fine I think.
v0lkan
approved these changes
Oct 26, 2026
v0lkan
left a comment
v0lkan
left a comment
Member
There was a problem hiding this comment.
LGTM. -- Didn't see anything fishy.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Some of the integration tests make specific expectations about k8s validation error messages. Some of those have changed in the upcoming k8s 1.38 release, so this PR updates the expected values in those tests. These are tested by the "integration-test-k8s-main" CI job, which runs Pinniped on a pre-release of the next k8s version.
Release note: