Add per-identity-provider override for Supervisor session lifetime - #3287
Open
JHansen2000 wants to merge 1 commit into
Open
Add per-identity-provider override for Supervisor session lifetime#3287JHansen2000 wants to merge 1 commit into
JHansen2000 wants to merge 1 commit into
Conversation
FederationDomain.spec.identityProviders[] now accepts an optional sessionLifetimeSeconds, letting administrators extend the default 9-hour refresh token lifetime for a specific identity provider. Addresses vmware#1004. Signed-off-by: Jacob Hansen <2000.jihansen@gmail.com>
✅ Deploy Preview for pinniped-dev ready!
To edit notification comments on pull requests, go to your Netlify project configuration. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Add per-identity-provider override for Supervisor session lifetime
Adds an optional
sessionLifetimeSecondsfield toFederationDomain.spec.identityProviders[], letting administrators override the Supervisor's default 9-hour refresh token lifetime on a per-identity-provider basis. This can be set shorter or longer than the default.This does not change how or when the upstream identity provider expires its own tokens or session- the upstream IDP's expiration still governs independently, and can still end a Supervisor session earlier than this value if it expires first. This setting only adjusts how long the Supervisor's own refresh token may be used before the user must interactively reauthenticate.
Documentation has been updated to describe the new field and its interaction with the existing 9-hour default.
The codegen tooling was used to regenerate the Go API code and CRD manifests under
generated/.Fixes #1004
Testing
main.main. New unit tests were added to cover this change.main. No new integration tests were added as part of this change.Release Note
Release note: