Upgrade k8s modules and linter - #3269
Open
cfryanr wants to merge 6 commits into
Open
Conversation
Signed-off-by: Ryan Richard <richardry@vmware.com>
Signed-off-by: Ryan Richard <richardry@vmware.com>
Signed-off-by: Ryan Richard <richardry@vmware.com>
Signed-off-by: Ryan Richard <richardry@vmware.com>
✅ Deploy Preview for pinniped-dev canceled.
|
Fix some test expectations and also fix the production code in impersonator.go to make them compatible with both Go 1.27 and also with older versions, e.g. Go 1.26. With these changes, all unit tests pass when run with either Go 1.26 or Go 1.27. Signed-off-by: Ryan Richard <richardry@vmware.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR:
go.moddependencies. Most notably, it upgrades the k8s modules to v0.37.0.impersonator.goto make them compatible with both Go 1.27 and also with older versions, e.g. Go 1.26. With these changes, all unit tests pass when run with either Go 1.26 or Go 1.27.Note to reviewers: Because this PR includes generated code, it will probably be easier to review each commit separately. The generated code shouldn't need human review since it is auto-generated.
Release note: