Skip to content

Fixing unexpected short fan activation when on level "0" for new gen Thinkpads #248

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
tova-cup wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Fixing unexpected short fan activation when on level "0" for new gen Thinkpads #248

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 5 additions & 1 deletion src/fans.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -139,7 +139,11 @@ void TpFanDriver::ping_watchdog_and_depulse(const Level &level)
}
else if (last_watchdog_ping_ + watchdog_ - sleeptime <= std::chrono::system_clock::now()) {
log(TF_DBG) << "Watchdog ping" << flush;
set_speed(level);
std::fstream f(path_);
if (!(f.is_open() && f.good()))
throw IOerror(MSG_FAN_INIT(path_), errno);
if (!(f << "watchdog " << watchdog_.count() << std::flush))
throw IOerror(MSG_FAN_INIT(path_), errno);

@ile371 ile371 May 18, 2026 •
edited
Loading

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Old open PR but can confirm this fix works! However, one side effect is that the Watchdog ping starts happening every cycle after the first one because the last_watch_dog_ping_ isn't set. Should set it at row 147 every time the else if runs similarly to what the set_speed function does:

Suggested change
throw IOerror(MSG_FAN_INIT(path_), errno);
throw IOerror(MSG_FAN_INIT(path_), errno);
last_watchdog_ping_ = std::chrono::system_clock::now();

}
}

Expand Down