feat(i18n): complete de/en/fr translations and add missing keys - #195
Open
sveneberth wants to merge 1 commit into
Open
feat(i18n): complete de/en/fr translations and add missing keys#195sveneberth wants to merge 1 commit into
sveneberth wants to merge 1 commit into
Conversation
Fill translation gaps in `data/translations.py`: - add French (`fr`) for all entries that were missing it - add English (`en`) for the VAT rate categories - add German (`de`) for `payment_provider.unzer-paypal` - add translations for keys referenced in code but absent from the dict: the `viur.shop.my_addresses` admin view label and the bone descriptions for `birthdate`, `shop_view_url`, `frozen_values`, `is_frozen`, `total_raw`, `OrderSkel.email`/`phone` and `VatIncludedSkel.value` Closes viur-framework#6
sveneberth
added
the
Priority: Low
sveneberth
requested review from
ArneGudermann,
KadirBalku,
akelch,
phneutral and
phorward
July 24, 2026 23:05
KadirBalku
previously approved these changes
Jul 24, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #6
Completes the translation dictionary in
src/viur/shop/data/translations.py.What changed
fr) added for every entry that was missing it.en) added for the VAT rate categories (standard,reduced,super_reduced,zero).de) added forpayment_provider.unzer-paypal.viur.shop.my_addresses(admin view label inmodules/address.py)AddressSkel.birthdate,ArticleAbstractSkel.shop_view_url,CartItemSkel.frozen_values/is_frozen,CartNodeSkel.frozen_values/is_frozen/total_raw,OrderSkel.email/phone,VatIncludedSkel.value_hint,_default_text, then languages alphabetically (de,en,fr), and missing trailing commas added.Notes
SelectBoneenum valuesOrderStateandShippingStatusare intentionally left out: they currently generate generic bare keys (paid,user, …) because notranslation_key_prefixis set on those bones. Namespacing them is a separate change and out of scope here.