Skip to content

fix: Don't refresh all cart leafs on every article write #188

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Draft
sveneberth wants to merge 2 commits into
base: main
Choose a base branch
from
Draft

fix: Don't refresh all cart leafs on every article write #188

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
ee24e84
fix: Don't refresh all cart leafs on every article write
sveneberth Jul 15, 2026
48f5798
Merge branch 'main' into fix/cart-article-update-level
sveneberth Jul 21, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
14 changes: 13 additions & 1 deletion src/viur/shop/skeletons/cart.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -438,7 +438,19 @@ class CartItemSkel(TreeSkel):
"shop_*",
],
consistency=RelationalConsistency.CascadeDeletion,
)
updateLevel=RelationalUpdateLevel.OnValueAssignment,
)
"""Relation to the article this cart item stands for.

The ``shop_*`` refKeys are a snapshot taken when the article is put
into the cart (see :meth:`Cart.copy_article_values` and the "frozen
copy" bones below); current prices are always computed live through
:attr:`price`. Therefore the relation uses
:attr:`RelationalUpdateLevel.OnValueAssignment`: with the default
(``Always``), every article write would spawn an ``update_relations``
task refreshing *every* cart leaf (including years-old abandoned
baskets) that references the article -- without any effect on the
prices being displayed or charged."""

quantity = NumericBone(
min=0,
Expand Down
Loading