Skip to content

fix(ui): simplify explorer filtering + fix nested tests when search matches a suite - #11262

Merged
sheremet-va merged 40 commits into
mainfrom
ui-explorer-projection
Oct 2, 2026
Merged

sheremet-va merged 40 commits into
mainfrom
ui-explorer-projection

Conversation

@hi-ogawa

@hi-ogawa hi-ogawa commented Sep 14, 2026 •

Copy link
Copy Markdown
Collaborator

The explorer tree filtering had grown into several complicated layers with global ref and generator, so this PR takes on a larger cleanup to establish a simpler pipeline. While doing this, I also found a minor issue with the expand toggle during search and fixed it. See the html artifact https://gisthost.github.io/?3cbab4603b1f5c72b83b78aafc228456/vitest-pr-11262-explain-diff.html for the high-level idea of the change.

The bug shows up when a search matches a suite with nested suites. For example, searching nested failure in the fixture test/ui/fixtures/main/suite-report.test.ts should give a tree like:

_nested failure_ suite        ← search matches
  failing nested suite
    failing nested child

but on main it gives:

_nested failure_ suite        ← search matches
  failing nested suite        ← shown with no tests under it

and collapsing and expanding failing nested suite doesn't bring failing nested child back. This PR shows the full tree in both cases.

This coverage is added in e2e.

Please don't delete this checklist! Before submitting the PR, please make sure you do the following:

  • It's really useful if your PR references an issue where it is discussed ahead of time. If the feature is substantial or introduces breaking changes without a discussion, PR might be closed.
  • Ideally, include a test that fails without this PR but passes with it.
  • Please, don't make changes to pnpm-lock.yaml unless you introduce a new test example.
  • Please check Allow edits by maintainers to make review process faster. Note that this option is not available for repositories that are owned by Github organizations.

Tests

  • Run the tests with pnpm test:ci.

Documentation

  • If you introduce new functionality, document it. You can run documentation with pnpm run docs command.

Changesets

  • Changes in changelog are generated from PR name. Please, make sure that it explains your changes in an understandable manner. Please, prefix changeset messages with feat:, fix:, perf:, docs:, or chore:.

hi-ogawa and others added 10 commits September 14, 2026 15:17
Co-authored-by: Codex <noreply@openai.com>
Co-authored-by: Codex <noreply@openai.com>
Co-authored-by: Codex <noreply@openai.com>
Co-authored-by: Codex <noreply@openai.com>
Co-authored-by: Codex <noreply@openai.com>
Co-authored-by: Codex <noreply@openai.com>
Co-authored-by: Codex <noreply@openai.com>
Co-authored-by: Codex <noreply@openai.com>
Co-authored-by: Codex <noreply@openai.com>
Co-authored-by: Codex <noreply@openai.com>
@netlify

netlify Bot commented Sep 14, 2026 •

Copy link
Copy Markdown

✅ Deploy Preview for vitest-dev ready!

Name Link
🔨 Latest commit 53bdaa0
🔍 Latest deploy log https://app.netlify.com/projects/vitest-dev/deploys/6abf1d356aab9f000802a9eb
😎 Deploy Preview https://deploy-preview-11262--vitest-dev.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.
🤖 Make changes Run an agent on this branch

To edit notification comments on pull requests, go to your Netlify project configuration.

hi-ogawa and others added 10 commits September 14, 2026 18:20
Co-authored-by: Codex <noreply@openai.com>
Co-authored-by: Codex <noreply@openai.com>
Co-authored-by: Codex <noreply@openai.com>
Co-authored-by: Codex <noreply@openai.com>
Co-authored-by: Codex <noreply@openai.com>
Co-authored-by: Codex <noreply@openai.com>
Co-authored-by: Codex <noreply@openai.com>

# Conflicts:
#	packages/ui/client/composables/explorer/expand.ts
Co-authored-by: Codex <noreply@openai.com>
Co-authored-by: Codex <noreply@openai.com>
Co-authored-by: Codex <noreply@openai.com>

# Conflicts:
#	packages/ui/client/composables/explorer/collapse.ts
#	packages/ui/client/composables/explorer/expand.ts
#	packages/ui/client/composables/explorer/filter.ts
#	packages/ui/client/composables/explorer/state.ts
@hi-ogawa
hi-ogawa changed the base branch from main to ui-filter-arrays September 15, 2026 02:16
@hi-ogawa
hi-ogawa added this pull request to stack #11272 September 15, 2026 02:26
@hi-ogawa
hi-ogawa removed this pull request from stack #11272 September 15, 2026 02:28
@hi-ogawa
hi-ogawa changed the base branch from ui-filter-arrays to main September 15, 2026 02:29
@hi-ogawa hi-ogawa changed the title refactor(ui): simplify explorer filtering fix(ui): simplify explorer filtering + fix nested tests when search matches a suite Oct 2, 2026
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
hi-ogawa and others added 17 commits October 2, 2026 12:42
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
@hi-ogawa
hi-ogawa marked this pull request as ready for review October 2, 2026 10:08
@sheremet-va
sheremet-va merged commit a627be4 into main Oct 2, 2026
29 checks passed
@sheremet-va
sheremet-va deleted the ui-explorer-projection branch October 2, 2026 13:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants