Skip to content

addr: propagate Protocol field in AddrUpdate subscriptions - #1201

Open
cgoncalves wants to merge 1 commit into
vishvananda:mainfrom
cgoncalves:ifaproto-update
Open

addr: propagate Protocol field in AddrUpdate subscriptions#1201
cgoncalves wants to merge 1 commit into
vishvananda:mainfrom
cgoncalves:ifaproto-update

Conversation

@cgoncalves

@cgoncalves cgoncalves commented Jul 16, 2026

Copy link
Copy Markdown
Contributor

The IFA_PROTO attribute was parsed in parseAddr but not included in the AddrUpdate struct or its construction in addrSubscribeAt, so address subscription consumers never saw the protocol value.

IFA_PROTO support added in #1157

Summary by CodeRabbit

  • New Features
    • Address-change notifications now include the protocol value associated with each address update.
    • Applications can read this new protocol metadata from the update information (e.g., for both address additions and deletions).

@coderabbitai

coderabbitai Bot commented Jul 16, 2026

Copy link
Copy Markdown

Review Change Stack

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info
⚙️ Run configuration

Configuration used: defaults

Review profile: CHILL

Plan: Pro

Run ID: 985ad1e8-ffbd-4e05-85c2-eaa148e03c5f

📥 Commits

Reviewing files that changed from the base of the PR and between 85cdcff and c28d43a.

📒 Files selected for processing (1)
  • addr_linux.go
🚧 Files skipped from review as they are similar to previous changes (1)
  • addr_linux.go

📝 Walkthrough

Walkthrough

AddrUpdate now exposes the kernel IFA_PROTO value, and address-change notifications populate this field from the parsed address state.

Changes

Address protocol propagation

Layer / File(s) Summary
Expose and populate address protocol
addr_linux.go
Adds the exported Protocol field to AddrUpdate and sets it for RTM_NEWADDR and RTM_DELADDR notifications.

Estimated code review effort: 1 (Trivial) | ~3 minutes

🚥 Pre-merge checks | ✅ 4 | ❌ 1

❌ Failed checks (1 warning)

Check name Status Explanation Resolution
Docstring Coverage ⚠️ Warning Docstring coverage is 0.00% which is insufficient. The required threshold is 80.00%. Write docstrings for the functions missing them to satisfy the coverage threshold.
✅ Passed checks (4 passed)
Check name Status Explanation
Description Check ✅ Passed Check skipped - CodeRabbit’s high-level summary is enabled.
Title check ✅ Passed The title clearly and accurately describes the main change: propagating Protocol in AddrUpdate subscriptions.
Linked Issues check ✅ Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check ✅ Passed Check skipped because no linked issues were found for this pull request.
✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands.

The IFA_PROTO attribute was parsed in parseAddr but not included in the
AddrUpdate struct or its construction in addrSubscribeAt, so address
subscription consumers never saw the protocol value.

Signed-off-by: Carlos Goncalves <cgoncalves@redhat.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant