Repository navigation
Conversation
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
read_images_binary()decodes image names one byte at a time, so valid UTF-8 names such ascafé.pngor场景.pngraiseUnicodeDecodeError. Accumulate the NUL-terminated name bytes and decode the complete name once, preserving strict UTF-8 error handling.COLMAP writes the complete name followed by NUL (official writer). Regression tests cover ASCII, two-/three-/four-byte UTF-8, mixed Chinese/emoji names, four consecutive records with varying point counts and aligned coordinates/IDs, and invalid UTF-8 rejection.
Validation on macOS arm64 / Python 3.9.6:
ruff checkandruff format --check: passed.pytest testsis blocked by missing Playwright. The non-E2E suite is blocked by missing client build/nodeenv; the complete suite was not run successfully.No GPU tests or real reconstruction datasets were used.