Skip to content

fix: preserve YAML frontmatter in skill fill #42

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
LorranHippolyte wants to merge 1 commit into
base: main
Choose a base branch
from
Open

fix: preserve YAML frontmatter in skill fill #42

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
14 changes: 13 additions & 1 deletion src/services/fill/skillFillService.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -12,6 +12,7 @@ import type { AgentEventCallbacks } from '../ai/agentEvents';
import type { LLMConfig } from '../../types';
import { resolveLlmConfig } from '../shared/llmConfig';
import { createSkillRegistry } from '../../workflow/skills';
import { parseFrontMatter, removeFrontMatter, addFrontMatter } from '../../utils/frontMatter';

export interface SkillFillCommandFlags {
output?: string;
Expand Down Expand Up @@ -267,6 +268,9 @@ export class SkillFillService {
console.log(''); // Add spacing before agent output

try {
// Preserve original frontmatter before calling the LLM
const { frontMatter: originalFrontMatter } = parseFrontMatter(existingContent);

const skillAgent = new SkillAgent(llmConfig);

const result = await skillAgent.generateSkill({
Expand All @@ -289,8 +293,16 @@ export class SkillFillService {
// Ensure directory exists
await fs.ensureDir(path.dirname(skillPath));

// Strip any frontmatter from LLM output, then rebuild with original
// metadata and status updated to 'filled'
const cleanBody = removeFrontMatter(result.text);
const updatedFrontMatter = originalFrontMatter
? { ...originalFrontMatter, status: 'filled' as const }
: { status: 'filled' as const };
const finalContent = addFrontMatter(cleanBody, updatedFrontMatter);

// Write the result
await fs.writeFile(skillPath, this.ensureTrailingNewline(result.text));
await fs.writeFile(skillPath, this.ensureTrailingNewline(finalContent));

console.log('');
this.ui.displaySuccess(this.t('spinner.skill.filled', { skill: skillSlug }));
Expand Down