feat(media): add symbol-backed media type guards - #2044
Draft
mihar-22 wants to merge 2 commits into
Draft
Conversation
✅ Deploy Preview for vjs10-site ready!
To edit notification comments on pull requests, go to your Netlify project configuration. |
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
Contributor
📦 Bundle Size Report🎨 @videojs/html — 29 small size changes
Presets (7)
Media (13)
Players (5)
Skins (30)
UI Components (39)
⚛️ @videojs/react — 56 small size changes
Presets (7)
Media (12)
Skins (27)
UI Components (33)
🧩 @videojs/core — 3 small size changes
Entries (76)
🏷️ @videojs/element — no changesEntries (2)
📦 @videojs/store — 1 small size change
Entries (3)
🔧 @videojs/utils — 3 small size changes
Entries (13)
📦 @videojs/jsx — no changesEntries (3)
📦 @videojs/media — 7 small size changes
Entries (15)
📦 @videojs/spf — 4 small size changes
Entries (7)
ℹ️ How to interpretEach entry is independently bundled, minified, and brotli-compressed. Initial size includes its static import graph; lazy dynamic chunks are reported separately. Entries are not additive because their dependency graphs overlap. Preset rows represent realistic combined bundles. Changes of 300 B or less across initial, lazy, and total size are collapsed, not discarded. Run |
mihar-22
marked this pull request as ready for review
August 11, 2026 18:15
mihar-22
marked this pull request as draft
August 11, 2026 18:46
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Add stable, symbol-backed identity checks for the Media facades so consumers can detect Media types without inferring them from playback-engine shape. Mux Data now chooses its hls.js and dash.js integrations from those Media checks while retaining engine-specific metadata validation where mux-embed requires it.
Changes
MuxMediais also recognized asHlsJsMediagetMediaEngine()as the shared safe utility for reading optional Media engineshasMethodspredicate from UtilsTesting
pnpm -F @videojs/media test(572 passed)pnpm -F @videojs/spf test(1,440 passed, 14 skipped)pnpm -F @videojs/utils test(417 passed, 3 skipped)pnpm -F @videojs/media buildpnpm -F @videojs/spf buildpnpm -F @videojs/utils buildpnpm exec tsgo --noEmit -p packages/media/tsconfig.jsonpnpm exec tsgo --noEmit -p packages/spf/tsconfig.jsonpnpm exec tsgo --noEmit -p packages/utils/tsconfig.jsonpnpm -F site api-docspnpm typecheckstill reports existing Store/HTML custom-element typing errors outside this diff; the affected Media, SPF, and Utils projects pass their direct typechecks.Note
Cursor Bugbot is generating a summary for commit b183728. Configure here.