refactor(packages)!: simplify menus - #2029
Draft
mihar-22 wants to merge 4 commits into
Draft
Conversation
✅ Deploy Preview for vjs10-site ready!
To edit notification comments on pull requests, go to your Netlify project configuration. |
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
Contributor
📦 Bundle Size Report🎨 @videojs/html
Small changes (18, ≤ 300 B)
Presets (7)
Media (13)
Players (5)
Skins (30)
UI Components (39)
⚛️ @videojs/react
Small changes (25, ≤ 300 B)
Presets (7)
Media (12)
Skins (27)
UI Components (33)
🧩 @videojs/core
Small changes (56, ≤ 300 B)
Entries (76)
🏷️ @videojs/element — no changesEntries (2)
📦 @videojs/store — 1 small size change
Entries (3)
🔧 @videojs/utils — 4 small size changes
Entries (13)
📦 @videojs/jsx — no changesEntries (3)
📦 @videojs/media
Small changes (4, ≤ 300 B)
Entries (15)
📦 @videojs/spf
Small changes (1, ≤ 300 B)
Entries (7)
ℹ️ How to interpretEach entry is independently bundled, minified, and brotli-compressed. Initial size includes its static import graph; lazy dynamic chunks are reported separately. Entries are not additive because their dependency graphs overlap. Preset rows represent realistic combined bundles. Changes of 300 B or less across initial, lazy, and total size are collapsed, not discarded. Run |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Refs #1994
Refs #2022
Summary
Continue the menu simplification exploration from #1994 while porting the useful state and composition ideas from #2022. Base menus now stay focused on generic menu behavior, while skins compose settings from menu and radio-group primitives and CSS transitions use the existing popover lifecycle.
Changes
open-changeevents stay synchronizedImplementation details
Submenu direction is inferred from local open state. Opening and closing reuse the popover transition lifecycle to expose starting and ending states, while a small shared height helper synchronizes the active panel height. There is no coordinator, viewport, view stack, direction channel, or settings controller.
This remains an exploratory draft; broader manual skin testing is intentionally left for review.
Testing
pnpm -F @videojs/core test— 91 files, 1,385 testspnpm -F @videojs/html test— 41 files, 299 testspnpm -F @videojs/react test— 39 files, 395 testspnpm -F @videojs/core buildpnpm -F @videojs/html buildpnpm -F @videojs/html build:cdnpnpm -F @videojs/react buildpnpm -F @videojs/skins buildpnpm -F @videojs/sandbox buildpnpm typecheckpnpm check:workspacegit diff --check