-
Notifications
You must be signed in to change notification settings - Fork 81
chore(root): add optional mise toolchain config #1894
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Changes from 2 commits
File filter
Filter by extension
Conversations
Jump to
Diff view
Diff view
There are no files selected for viewing
| Original file line number | Diff line number | Diff line change | ||||
|---|---|---|---|---|---|---|
| @@ -0,0 +1,30 @@ | ||||||
| # Optional convenience for contributors who use mise (https://mise.jdx.dev). | ||||||
| # | ||||||
| # mise is not required. `.node-version`/`.nvmrc` (Node) and `packageManager` | ||||||
| # (pnpm) stay the source of truth, so nvm, Volta, and CI never drift from this | ||||||
| # file. See "Using mise" in CONTRIBUTING.md. | ||||||
| min_version = "2025.1.0" | ||||||
|
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Incorrect mise min_version floorLow Severity
Suggested change
Reviewed by Cursor Bugbot for commit 286e914. Configure here. |
||||||
|
|
||||||
| [settings] | ||||||
| # Resolve Node from `.nvmrc`/`.node-version` instead of duplicating the pin. | ||||||
| # Idiomatic version files are opt-in per project, and older mise releases spell | ||||||
| # this setting differently — `min_version` above turns that into a loud error | ||||||
| # rather than a silently unpinned Node. | ||||||
| idiomatic_version_file_enable_tools = ["node"] | ||||||
|
|
||||||
| [tools] | ||||||
| # Mirrors `packageManager` in package.json; `pnpm check:workspace` enforces it. | ||||||
| # Node is deliberately absent — see `[settings]` above. | ||||||
| pnpm = "11.17.0" | ||||||
|
|
||||||
| [env] | ||||||
| # Expose workspace binaries (biome, turbo, tsgo, prettier, tsx) directly, so | ||||||
| # they can be invoked without a `pnpm exec` prefix. | ||||||
| _.path = ["{{config_root}}/node_modules/.bin"] | ||||||
|
|
||||||
| # Personal, gitignored overrides. Skipped when the file does not exist. | ||||||
| _.file = { path = ".env.local", redact = true } | ||||||
|
|
||||||
| [tasks.setup] | ||||||
| description = "Install dependencies and build workspace packages" | ||||||
| run = ["pnpm install", "pnpm build:packages"] | ||||||


There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Settings check matches comments
Medium Severity
The idiomatic-version-file check matches the assignment anywhere in the
[settings]body, including comments. Commenting outidiomatic_version_file_enable_tools = ["node"]still satisfies the regex, socheck:workspacecan pass while mise users get no Node pin.Reviewed by Cursor Bugbot for commit 286e914. Configure here.