feat(docker): add build arg VERNEMQ_TARBALL_URL for custom binary distro#426
Open
niecore wants to merge 1 commit into
Open
feat(docker): add build arg VERNEMQ_TARBALL_URL for custom binary distro#426niecore wants to merge 1 commit into
niecore wants to merge 1 commit into
Conversation
To be EULA compliant a own VerneMQ build has to be used. This feature was introduced in vernemq#83 but later removed in vernemq#172. This PR adds docker build arguments `VERNEMQ_TARBALL_URL` that allow users to configure an own binary package. In addition the curl download has been replaced with the docker native `ADD` command which resolves urls, and caches the downloaded binary. This even allows to use local builds without using an http download by setting `VERNEMQ_TARBALL_URL` to an local file. The architecture of the download is evaluated by dockers `TARGETARCH` argument. This can be used to build for multiple plattforms i.e. by setting `--platform linux/amd64,linux/arm64` as build arguments.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
To be EULA compliant a own VerneMQ build has to be used. This feature was introduced in #83 but later removed in #172. This PR adds docker build arguments
VERNEMQ_TARBALL_URLthat allow users to configure an own binary package.In addition the curl download has been replaced with the docker native
ADDcommand which resolves urls, and caches the downloaded binary. This even allows to use local builds without using an http download by settingVERNEMQ_TARBALL_URLto an local file.The architecture of the download is evaluated by dockers
TARGETARCHargument. This can be used to build for multiple plattforms i.e. by setting--platform linux/amd64,linux/arm64as build arguments.