Skip to content

breaking change!: only ship ESM (and drop Node 18) #264

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
dimitropoulos merged 3 commits into from
Aug 27, 2025
+6 −10
Merged

breaking change!: only ship ESM (and drop Node 18) #264

Show file tree
Hide file tree
Changes from 2 commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
8d5e97e
remove node 18 support
dimitropoulos Aug 27, 2025
46a71ae
only ship esm
dimitropoulos Aug 27, 2025
b1bbfb8
remove `main` field
dimitropoulos Aug 27, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion .github/workflows/test.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -13,7 +13,7 @@ jobs:
strategy:
fail-fast: false
matrix:
node: [18, 20, 22, 24]
node: [20, 22, 24]
task: [test:nodejs, test:edge]

steps:
Expand Down
13 changes: 5 additions & 8 deletions package.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -6,25 +6,22 @@
"type": "git",
"url": "git+https://github.com/vercel/ms.git"
},
"main": "./dist/index.cjs",
"types": "./dist/index.d.cts",
"main": "./dist/index.js",
Comment thread
dimitropoulos marked this conversation as resolved.
Outdated
"types": "./dist/index.d.ts",
"type": "module",
"exports": {
".": {
"import": {
"types": "./dist/index.d.ts",
"default": "./dist/index.js"
},
"require": {
"types": "./dist/index.d.cts",
"default": "./dist/index.cjs"
}
"default": "./dist/index.js"
}
},
"sideEffects": false,
"license": "MIT",
"engines": {
"node": ">=18"
"node": ">=20"
Comment thread
dimitropoulos marked this conversation as resolved.
},
"packageManager": "pnpm@10.14.0-0+sha512.2cd47a0cbf5f1d1de7693a88307a0ede5be94e0d3b34853d800ee775efbea0650cb562b77605ec80bc8d925f5cd27c4dfe8bb04d3a0b76090784c664450d32d6",
"files": [
Expand All @@ -38,7 +35,7 @@
"lint": "biome lint",
"format": "biome format",
"typecheck": "tsc --noEmit",
"attw": "pnpm build && attw --pack .",
"attw": "pnpm build && attw --pack --profile esm-only .",
"precommit": "lint-staged",
"prepare": "husky"
},
Expand Down
2 changes: 1 addition & 1 deletion tsdown.config.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2,7 +2,7 @@ import { defineConfig } from 'tsdown';

export default defineConfig({
entry: ['src/index.ts'],
format: ['cjs', 'esm'],
format: ['esm'],
dts: true,
sourcemap: true,
clean: true,
Expand Down