fix(eve): preserve execution caller across approval responses - #3079
Open
aatosolavi wants to merge 1 commit into
Open
fix(eve): preserve execution caller across approval responses#3079aatosolavi wants to merge 1 commit into
aatosolavi wants to merge 1 commit into
Conversation
Signed-off-by: Aatos Akvilander <aatos@akvilander.com>
Contributor
|
@aatosolavi is attempting to deploy a commit to the Vercel Team on Vercel. A member of the Team first needs to authorize it. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
When an operator answers a parked approval or session-limit prompt, eve replaces the suspended caller with the responder, so resumed user-scoped work can run as the operator service. Preserve the active caller for authenticated responses to live control requests, pass tool responses through the existing attributed-response path for authorization and audit, and keep buffered deliveries with different auth contexts separate. New messages, question answers, stale responses, and unauthenticated responses retain their existing caller behavior; this does not fall back to the session initiator.
Validation
Reproduced the bug on unmodified
1807ff9c: all three new workflow regression cases fail. With this change, the direct continuation, queued user work, and a caller different from the initiator pass.pnpm --filter eve exec vitest run --config vitest.unit.config.ts src/execution/input-response-auth.test.ts src/execution/workflow-steps.test.ts src/execution/parked-delivery-wait.test.ts src/internal/structural-tests/file-length.test.ts— 71 passed.pnpm --filter eve exec vitest run --config vitest.integration.config.ts src/execution/approval-caller.integration.test.ts src/execution/session-limit-cancellation.integration.test.ts src/harness/tool-loop-generate-approval-resume.integration.test.ts— 16 passed; after adding the operator policy/audit/tool execution assertion, reran the tool-loop file: 12 passed (17 distinct integration cases total).pnpm --filter eve exec tsc -p tsconfig.json --noEmit,pnpm --filter agent-tools-hitl exec tsc --noEmit, targetedoxlint/format checks,pnpm guard:invariants, andpnpm docs:checkpassed. Built compiled dependencies and package JS before integration tests.Full unit suite: 8,100 passed, 1 skipped, 5 failed. The same five failures reproduce with unmodified production sources on this macOS checkout: three callback-log redaction assertions match
/private/tmpin stack traces; two telemetry preference assertions expect Linux config paths. No new failures remain.Added a real-model HTTP approval eval to
agent-tools-hitl; not run locally, per the repository's CI-only E2E rule. All local regression tests use synthetic identities and a mock model; no production sessions were resumed or cancelled.Upstream CI/E2E workflows currently require maintainer approval for this fork (
action_required); Vercel preview deployments also require authorization. DCO and commit signature verification pass.Checklist
CONTRIBUTING.mdevepackagegit commit --signoff)