Skip to content

feat(slack): add private approval previews - #3061

Draft
benpankow wants to merge 1 commit into
benpankow/turn-commit-rollbackfrom
benpankow/slack-private-approval-preview
Draft

feat(slack): add private approval previews#3061
benpankow wants to merge 1 commit into
benpankow/turn-commit-rollbackfrom
benpankow/slack-private-approval-preview

Conversation

@benpankow

@benpankow benpankow commented Sep 4, 2026

Copy link
Copy Markdown
Collaborator

Summary

Adds private delivery for Slack tool approvals. privateToolApprovals can put the preview and controls in an ephemeral thread message or reviewer DM; DM interactions carry the original thread route so they resume the correct parked session. Questions and session-limit prompts keep their existing thread behavior, and missing reviewer identity fails closed without a public fallback.

export default slackChannel({
  privateToolApprovals: {
    delivery: "direct-message", // or "ephemeral"
    when: (request) => request.action.toolName === "review_answer",
    reviewer: (_request, ctx) =>
      String(ctx.session.auth.current?.attributes.reviewerUserId ?? "") || null,
  },
});

Direct messages require the Slack app's im:write scope. This builds on #3055 and #3056; it does not change approval authorization policy.

Validation

Adds tests for ephemeral and DM preview delivery, reviewer targeting, return-route encoding, response decoding, and DM card settlement state.

🤖

@vercel

vercel Bot commented Sep 4, 2026

Copy link
Copy Markdown
Contributor

The latest updates on your projects. Learn more about Vercel for GitHub.

Project Deployment Actions Updated
eve-docs Ready Ready Preview Sep 4, 2026 10:46pm UTC
eve-docs-4759 Ready Ready Preview, v0 Sep 4, 2026 10:46pm UTC
eve-pkg Ready Ready Preview Sep 4, 2026 10:46pm UTC

@github-actions

github-actions Bot commented Sep 4, 2026

Copy link
Copy Markdown
Contributor

Bundle + Package Summary: apps/fixtures/weather-agent

Key takeaways

  • No notable deltas vs benpankow/turn-rollback-tasks (be6194b).

Delta vs benpankow/turn-rollback-tasks (be6194b)

Area Metric Baseline Current Delta
Package Packed tarball 8.65 MB 8.65 MB +1.7 kB ⚠️
Package Unpacked publish size 32.59 MB 32.59 MB +5.3 kB ⚠️
Package Installed footprint 77.67 MB 77.67 MB +5.3 kB ⚠️
Package Published files 3841 3841 0
Package Installed files 7739 7739 0
Package Installed package instances 33 33 0
Package Distinct installed package names 32 32 0
Package Installed dependency edges 51 51 0
Package Installed optional peer edges 7 7 0
Runtime Unique function payloads 2 2 0
Runtime Total function bytes 20.72 MB 20.72 MB -80 B ✅
Runtime Public routes 18 18 0
Changed function payloads vs benpankow/turn-rollback-tasks (be6194b) (2)
Function Status Baseline Current Delta Route changes
functions/__server.func changed 10.36 MB 10.36 MB -40 B ✅ none
functions/.well-known/workflow/v1/flow.func changed 10.36 MB 10.36 MB -40 B ✅ none

eve init install

Metric Baseline Current Delta
Installed footprint 116.10 MB 116.11 MB +5.3 kB ⚠️
Installed packages 113 113 0
dependencies 4 4 0
devDependencies 2 2 0
Dependency package bytes 48.71 MB 48.72 MB +5.3 kB ⚠️
devDependency package bytes 5.04 MB 5.04 MB 0 B ➖
Build Metadata
  • Preset: vercel
  • Nitro: nitro@3.0.260903-beta
  • Output directory: apps/fixtures/weather-agent/.vercel/output
  • Build metadata timestamp: 2026-09-04T22:47:26.826Z
  • Route aliases: 18 public, 1 internal (19 total aliases)
  • Vercel routes in config: 21
  • Severity legend: 🔴 dominant/large, 🟠 notable, 🟡 watch, ⚪ small
Package Drill-Down

Package Details

  • Package: eve@0.52.0
  • Package directory: packages/eve
  • Tarball: 8.65 MB (eve-0.52.0.tgz)
  • Unpacked payload: 32.59 MB across 3841 published files
  • Installed footprint: 77.67 MB across 7739 installed files
  • Installed root package: 31.16 MB
  • Installed dependencies: 46.51 MB
  • Installed package instances: 33
  • Distinct installed package names: 32
  • Installed dependency edges: 51
  • Installed optional peer edges: 7
  • Runtime dependencies: 2
  • Peer dependencies: 5 (4 optional)

Installed footprint is measured from an isolated temporary npm install of the packed tarball.
Graph metrics read only package.json files in package directories directly beneath a node_modules boundary, including nested boundaries. Each directory is one package instance; distinct names come from those manifests. Dependency edges count each unique name in dependencies or optionalDependencies per instance; optional peer edges count peerDependencies marked optional.

Heavy installed dependencies

  • eve: 31.16 MB (40.1%)
  • @rolldown/binding-linux-x64-gnu: 19.31 MB (24.9%)
  • ai: 7.01 MB (9.0%)
  • zod: 6.41 MB (8.3%)
  • undici: 3.51 MB (4.5%)
Publish payload breakdown
Published file size
🔴 dist/src/compiled/shadcn-registry/index.js       [#############...........] 9.76 MB 29.9%
🟠 dist/src/compiled/@photon-ai/chat-adapter-ime... [###.....................] 2.27 MB 7.0%
🟠 dist/src/compiled/@ai-sdk/code-mode/index.js     [#.......................] 1.03 MB 3.1%
🟡 dist/src/compiled/@vercel/blob/index.js          [#.......................] 901.4 kB 2.8%
🟡 dist/src/compiled/_chunks/workflow/signal-exi... [#.......................] 514.6 kB 1.6%
🔴 Other published files                            [########################] 18.12 MB 55.6%
Installed footprint breakdown
Installed package size
🔴 eve                             [########################] 31.16 MB 40.1%
🔴 @rolldown/binding-linux-x64-gnu [###############.........] 19.31 MB 24.9%
🔴 ai                              [#####...................] 7.01 MB 9.0%
🔴 zod                             [#####...................] 6.41 MB 8.3%
🟠 undici                          [###.....................] 3.51 MB 4.5%
🟠 nitro                           [#.......................] 1.89 MB 2.4%
🔴 Other installed packages        [######..................] 8.36 MB 10.8%
Runtime dependencies (2)
Package Range Notes
nitro 3.0.260903-beta
undici 8.9.0
Peer dependencies (5)
Package Range Notes
@opentelemetry/api ^1.0.0 optional peer
ai catalog:
braintrust ^3.0.0 optional peer
just-bash ^3.1.0 optional peer
microsandbox ^0.5.0 optional peer
eve init install drill-down

eve init install details

  • Command: eve init my-agent
  • Package manager: npm
  • Installed footprint: 116.11 MB across 9635 installed files
  • Installed packages: 113 total (107 transitive-only)
  • dependencies: 4 direct packages totaling 48.72 MB
  • devDependencies: 2 direct packages totaling 5.04 MB
  • Other transitive package files: 62.35 MB

Installed footprint is measured from an isolated temporary eve init my-agent using the current packed eve tarball.

Heavy installed dependencies

  • eve: 31.16 MB (26.8%)
  • @typescript/typescript-linux-x64: 27.95 MB (24.1%)
  • @rolldown/binding-linux-x64-gnu: 19.31 MB (16.6%)
  • zod: 10.37 MB (8.9%)
  • ai: 7.01 MB (6.0%)
Installed footprint breakdown
Installed package size
🔴 eve                              [########################] 31.16 MB 26.8%
🔴 @typescript/typescript-linux-x64 [######################..] 27.95 MB 24.1%
🔴 @rolldown/binding-linux-x64-gnu  [###############.........] 19.31 MB 16.6%
🔴 zod                              [########................] 10.37 MB 8.9%
🔴 ai                               [#####...................] 7.01 MB 6.0%
🟠 undici                           [###.....................] 3.51 MB 3.0%
🔴 Other installed packages         [#############...........] 16.79 MB 14.5%
dependencies (4)
Package Range Installed size Share
@vercel/connect 1.0.0 167.9 kB 0.1%
ai ^7.0.82 7.01 MB 6.0%
eve file:eve-0.52.0.tgz 31.16 MB 26.8%
zod 4.5.4 10.37 MB 8.9%
devDependencies (2)
Package Range Installed size Share
@types/node 24.x 2.54 MB 2.2%
typescript 7.0.2 2.50 MB 2.2%
Function Drill-Down

Payload Size Graph

Unique function payload size and share of total
🔴 functions/.well-known/workflow/v1/flow.func     [########################] 10.36 MB 50.0%
🔴 functions/__server.func                         [########################] 10.36 MB 50.0%

Top Function Payloads

🟠 functions/.well-known/workflow/v1/flow.func • 1 public route • 10.36 MB
Metric Value
Public routes /.well-known/workflow/v1/flow
Runtime nodejs24.x
Handler index.mjs
Payload 10.36 MB
Function files 10.36 MB across 112 files
Traced dependencies 0 B
Signal 🟠 Bundled file index.mjs is 2.32 MB (22.4%)

🟠 🔎 Dependency Analysis

📦 Bundled files:

Bundled file size
🟠 index.mjs                        [###########.............] 2.32 MB 22.4%
🟡 _libs/undici.mjs                 [#####...................] 980.8 kB 9.5%
🟡 _chunks/esm-Fqlolk7e.mjs         [###.....................] 723.3 kB 7.0%
🟡 _chunks/chatgpt-model.mjs        [###.....................] 695.8 kB 6.7%
🟡 _chunks/signal-exit-Dsy-TT0V.mjs [###.....................] 616.2 kB 5.9%
🔴 Other bundled files              [########################] 5.03 MB 48.5%

🧾 Vercel Config

{
  "handler": "index.mjs",
  "launcherType": "Nodejs",
  "shouldAddHelpers": false,
  "supportsResponseStreaming": true,
  "runtime": "nodejs24.x",
  "maxDuration": "max",
  "experimentalTriggers": [
    {
      "type": "queue/v2beta",
      "topic": "__eve776561746865722d6167656e74_wkf_workflow_*",
      "consumer": "default",
      "retryAfterSeconds": 5,
      "initialDelaySeconds": 0
    }
  ],
  "environment": {
    "WORKFLOW_PRECONDITION_GUARD": "1"
  }
}

🟠 functions/__server.func • 17 public routes, 1 internal alias • 10.36 MB
Metric Value
Public routes /
/.well-known/workflow/v1/webhook/[token]
/eve/v1/activity/[token]
/eve/v1/callback/[token]
/eve/v1/connections/[name]/callback/[attemptId]/[token]
/eve/v1/connections/[name]/callback/[token]
/eve/v1/health
/eve/v1/info
/eve/v1/session
/eve/v1/session/[parentSessionId]/subagents/[callId]/[childSessionId]/stream
/eve/v1/session/[sessionId]
/eve/v1/session/[sessionId]/cancel
/eve/v1/session/[sessionId]/clear
/eve/v1/session/[sessionId]/compact
/eve/v1/session/[sessionId]/reset
/eve/v1/session/[sessionId]/stream
/eve/v1/task-input/[token]
Internal aliases /__server
Runtime nodejs24.x
Handler index.mjs
Payload 10.36 MB
Function files 10.36 MB across 112 files
Traced dependencies 0 B
Signal 🟠 Bundled file index.mjs is 2.32 MB (22.4%)

🟠 🔎 Dependency Analysis

📦 Bundled files:

Bundled file size
🟠 index.mjs                        [###########.............] 2.32 MB 22.4%
🟡 _libs/undici.mjs                 [#####...................] 980.8 kB 9.5%
🟡 _chunks/esm-Fqlolk7e.mjs         [###.....................] 723.3 kB 7.0%
🟡 _chunks/chatgpt-model.mjs        [###.....................] 695.8 kB 6.7%
🟡 _chunks/signal-exit-Dsy-TT0V.mjs [###.....................] 616.2 kB 5.9%
🔴 Other bundled files              [########################] 5.03 MB 48.5%

🧾 Vercel Config

{
  "handler": "index.mjs",
  "launcherType": "Nodejs",
  "shouldAddHelpers": false,
  "supportsResponseStreaming": true,
  "runtime": "nodejs24.x"
}

Build Timing: e2e/fixtures/agent-tools-sandbox

This is an informational timing measurement inside eve build, from preflight through publication. Output-size measurement and profile writing are excluded.

Build mode: deployable Vercel build with sandbox template prewarm included.

  • Build pipeline: 2.43 s -> 2.34 s (-93.3 ms) vs benpankow/turn-rollback-tasks (be6194b).
  • Timing is informational: shared GitHub runners are too variable for a hard timing budget.
Detailed phase timings vs `benpankow/turn-rollback-tasks (be6194b)`
Phase Baseline Current Delta
extension.check 11.3 ms 13.8 ms +2.5 ms
project.resolve 0.3 ms 6.0 ms +5.7 ms
workspace.create 0.6 ms 0.8 ms +0.2 ms
host.prepare 444.2 ms 384.2 ms -60.0 ms
vercel.service-prefix.resolve 1.4 ms 1.5 ms +0.1 ms
nitro.create 420.3 ms 395.3 ms -25.0 ms
sandbox.prewarm 288.4 ms 315.0 ms +26.6 ms
nitro.cache.prepare 0.3 ms 0.3 ms 0.0 ms
nitro.prepare 0.9 ms 0.7 ms -0.2 ms
nitro.public-assets 0.5 ms 0.6 ms +0.1 ms
nitro.prerender 0.4 ms 0.3 ms -0.1 ms
nitro.bundle 1.21 s 1.13 s -81.5 ms
nitro.cache.write 0.3 ms 0.3 ms 0.0 ms
vercel.workflow-function.materialize 46.0 ms 72.0 ms +26.0 ms
agent-summary.emit 0.7 ms 0.6 ms -0.1 ms
nitro.close 0.1 ms 0.1 ms 0.0 ms
output.publish 3.0 ms 15.1 ms +12.1 ms
workspace.remove 1.6 ms 1.8 ms +0.2 ms

@vercel vercel Bot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Additional Suggestion:

In task-mode turns, the TurnCommitEventGate withholds the terminal message.completed event but nothing ever releases it (and a turn-commit checkpoint is created but never resolved) whenever the bundle registers any beforeTurnCommit hook.

Fix on Vercel

Signed-off-by: benpankow <ben.pankow@vercel.com>
@benpankow
benpankow force-pushed the benpankow/slack-private-approval-preview branch from dc704e6 to 15bfaa9 Compare September 4, 2026 22:44
@benpankow benpankow changed the title [3/3] feat(slack): add private approval previews feat(slack): add private approval previews Sep 4, 2026
@benpankow
benpankow force-pushed the benpankow/turn-rollback-tasks branch from be6194b to fbb95c9 Compare September 4, 2026 22:53
Base automatically changed from benpankow/turn-rollback-tasks to benpankow/turn-commit-rollback September 4, 2026 22:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant