Conversation
gt/gte/lt/lte required both sides to be typeof number. YAML-quoted and LLM-generated counts are strings, so a gt: 3 condition hid the element when count was "5". Coerce numeric strings the same way lessThan/greaterThan validation already does. Empty and non-numeric strings still fail the comparison.
Contributor
|
@kevin9327 is attempting to deploy a commit to the Vercel Labs Team on Vercel. A member of the Team first needs to authorize it. |
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Visibility
gt/gte/lt/lterequired both sides to betypeof number. YAML-quoted and LLM-generated state values are often strings, so{ "$state": "/count", "gt": 3 }hid the element whencountwas"5".Coerce numeric strings the same way
lessThan/greaterThanvalidation already does. Empty strings,"10px", and booleans still fail the comparison.Testing
pnpm exec vitest run packages/core/src/visibility.test.tspnpm test(1215 passed)AI-assisted (Grok)