Conversation
findFormValue skipped any string containing a dot, treating it as a state path. Emails, URLs, and versions were dropped, so the dashboard create-customer handler never saw john.doe@example.com. Only identifier.identifier strings are path refs now.
Contributor
|
@kevin9327 is attempting to deploy a commit to the Vercel Labs Team on Vercel. A member of the Team first needs to authorize it. |
Collaborator
|
Thanks for the PR! Addressed in #353 and added you as a co-author. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
findFormValueskipped any param whose value contained a., on the assumption it was a dotted state path likeform.email. Real field values also contain dots:john.doe@example.com,https://example.com,1.2.3. Those were dropped, so the dashboard create-customer handler never received the email.Only identifier.identifier strings are treated as path refs now. Emails, URLs, and versions are returned as literals.
form.emailstill resolves against state.Testing
pnpm exec vitest run packages/core/src/types.test.ts -t findFormValuepnpm test(1216 passed)AI-assisted (Grok)