Conversation
Contributor
|
@ROTl24 is attempting to deploy a commit to the Vercel Labs Team on Vercel. A member of the Team first needs to authorize it. |
Escape tilde and slash characters in each object key before appending it to the JSON Pointer prefix. This prevents literal slash-containing keys from colliding with nested paths and lets state-store reads and writes resolve tilde-containing keys correctly. Preserve existing prefixes and document the escaping behavior in the core README and skill. Add regression coverage for path collisions, nested escaping with an existing prefix, and state-store read/write round trips. All three tests fail before the fix and pass after it. The 545 standalone core tests and the core build, including declaration generation, pass. Full core tests, tsc, and workspace type-check remain blocked by missing cross-workspace dependencies in the selective install. Browser UI behavior was not tested.
ROTl24
force-pushed
the
fix/flatten-json-pointer-keys
branch
from
September 19, 2026 15:07
c45c749 to
80ca66a
Compare
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
flattenToPointers({ "a/b": 1, a: { b: 2 } })currently returns only{ "/a/b": 2 }: the two keys collide. Keys containing~also produce paths that don't read back correctly throughstore.get. The devtools state tab uses these paths for inline edits, so this can hide an entry or write to a different key.Escape each key using JSON Pointer's
~0and~1sequences before appending it to the prefix. Added regressions for the collision, nested escaping with an existing prefix, and reading/writing the resulting paths through a state store. All three fail before the fix and pass after it.Validation on Windows / Node 24.19.0:
pnpm exec vitest run packages/core/src --exclude '**/repeat-schema-parity.test.ts': 545 tests passed.pnpm --filter @json-render/core build: passed, including declaration generation.tscandpnpm type-checkwere attempted but couldn't complete with the core-only dependency install: the cross-renderer parity test needs other workspace packages, and the workspace check stops on missing Next.js dependencies inexample-gsplat.No browser UI test was run.