Skip to content

attesters: add NVIDIA GPU evidence plugin - #74

Merged
cowbon merged 8 commits into
mainfrom
gpu-attester
Jul 22, 2026
Merged

attesters: add NVIDIA GPU evidence plugin#74
cowbon merged 8 commits into
mainfrom
gpu-attester

Conversation

@cowbon

@cowbon cowbon commented May 22, 2026

Copy link
Copy Markdown
Collaborator

No description provided.

cowbon added 5 commits July 16, 2026 11:47
Signed-off-by: Ian Chin Wang <ian.chin.wang@oracle.com>
Signed-off-by: Ian Chin Wang <ian.chin.wang@oracle.com>
Signed-off-by: Ian Chin Wang <ian.chin.wang@oracle.com>
Signed-off-by: Ian Chin Wang <ian.chin.wang@oracle.com>
Signed-off-by: Ian Chin Wang <ian.chin.wang@oracle.com>

@jraman567 jraman567 left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi Tom,

Thanks for the PR! I left some comments.

Thank you,
Jag

Comment thread attesters/gpu/gpu.go Outdated
Comment thread tokens/gpu-evidence.go Outdated
Comment thread tokens/gpu-evidence.go Outdated
Comment thread tokens/gpu-evidence.go Outdated
Comment thread tokens/gpu-evidence.go Outdated
Comment thread tokens/gpu-evidence.go Outdated
Comment thread attesters/gpu/gpu.go Outdated
Signed-off-by: Ian Chin Wang <ian.chin.wang@oracle.com>
@cowbon

cowbon commented Jul 21, 2026

Copy link
Copy Markdown
Collaborator Author

Hi Tom,

Thanks for the PR! I left some comments.

Thank you, Jag

Hi @jraman567 , thanks for the review. The followings are the latest changes

  • Renamed the attester/package to nvgpu.
  • Simplified GPU JSON encoding and removed wire/CBOR helpers.
  • Uses NVIDIA’s NVML nonce-size constant.
  • Changed Valid to a value receiver.
  • Moved the NVML availability probe to plugin initialization.
  • Documented NVIDIA driver/runtime prerequisites.
  • Updated the CDDL nonce encoding to match standard JSON base64.

@cowbon
cowbon requested a review from jraman567 July 21, 2026 21:31

@jraman567 jraman567 left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, @cowbon ! LGTM!

Please note the additional comments I left concerning value receiver.

Comment thread attesters/nvgpu/nvgpu.go Outdated
Comment thread tokens/gpu-evidence.go Outdated
Signed-off-by: Ian Chin Wang <ian.chin.wang@oracle.com>
Signed-off-by: Ian Chin Wang <ian.chin.wang@oracle.com>
@cowbon
cowbon merged commit 9afc706 into main Jul 22, 2026
2 checks passed
@cowbon
cowbon deleted the gpu-attester branch July 22, 2026 17:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants