Conversation
gquintard
marked this pull request as draft
August 18, 2026 01:22
gquintard
force-pushed
the
go-yq
branch
3 times, most recently
from
August 18, 2026 05:27
66dda45 to
0743746
Compare
gquintard
requested review from
audunmg and
briiians
and
a lite review from Copilot
August 18, 2026 05:28
There was a problem hiding this comment.
Pull request overview
Updates the chart unit-test suite to use Go yq (mikefarah/yq v4-style flags) instead of the Python yq wrapper, aligning test JSON extraction and type assertions across the charts. This supports ongoing work like #117 by making CI/test tooling more predictable and removing a Python dependency from the pipeline.
Changes:
- Replace Python-yq-style
yq -r -cusage withyq -o=json -I=0(plus-rwhere needed) across BATS unit tests. - Adjust type assertions from jq-style (
string/number) to go-yq tag outputs (!!str/!!int) where applicable. - Remove
pip install yqfrom CI (but CI still needs an explicit go-yq install; see comment).
Reviewed changes
Copilot reviewed 34 out of 35 changed files in this pull request and generated 1 comment.
Show a summary per file
| File | Description |
|---|---|
| varnish-enterprise/test/unit/statefulset.bats | Switch JSON extraction to go-yq flags for StatefulSet assertions. |
| varnish-enterprise/test/unit/service.bats | Switch JSON extraction to go-yq flags for Service assertions. |
| varnish-enterprise/test/unit/pdb.bats | Switch extraction to go-yq flags and update type expectations to !!*. |
| varnish-enterprise/test/unit/hpa.bats | Switch extraction to go-yq flags and update type expectations to !!int. |
| varnish-enterprise/test/unit/extra.bats | Switch multi-doc/object filtering to go-yq JSON output. |
| varnish-enterprise/test/unit/deployment.bats | Switch JSON extraction to go-yq flags for Deployment assertions. |
| varnish-enterprise/test/unit/daemonset.bats | Switch JSON extraction to go-yq flags for DaemonSet assertions. |
| varnish-enterprise/test/unit/cluster.bats | Switch JSON extraction to go-yq flags for cluster-related templates. |
| varnish-controller/test/unit/service-ui.bats | Switch annotations extraction to go-yq flags. |
| varnish-controller/test/unit/service-apigw.bats | Switch annotations extraction to go-yq flags. |
| varnish-controller/test/unit/secret-credentials.bats | Switch secret field extraction to go-yq flags. |
| varnish-controller/test/unit/imagePullSecrets.bats | Switch imagePullSecrets extraction to go-yq flags. |
| varnish-controller/test/unit/hpa-ui.bats | Switch extraction to go-yq flags and update type expectations to !!int. |
| varnish-controller/test/unit/hpa-brainz.bats | Switch extraction to go-yq flags and update type expectations to !!int. |
| varnish-controller/test/unit/hpa-apigw.bats | Switch extraction to go-yq flags and update type expectations to !!int. |
| varnish-controller/test/unit/extra.bats | Switch multi-doc/object filtering and checksum reads to go-yq JSON output. |
| varnish-controller/test/unit/deployment-ui.bats | Switch Deployment UI assertions to go-yq flags throughout. |
| varnish-controller/test/unit/deployment-brainz.bats | Switch Deployment brainz assertions to go-yq flags throughout. |
| varnish-controller/test/unit/deployment-apigw.bats | Switch Deployment apigw assertions to go-yq flags throughout. |
| varnish-controller-router/test/unit/service-router-management.bats | Switch service/router-management assertions to go-yq flags. |
| varnish-controller-router/test/unit/service-router-http.bats | Switch service/router-http assertions to go-yq flags. |
| varnish-controller-router/test/unit/service-router-dns-backend.bats | Switch service/router-dns-backend assertions to go-yq flags. |
| varnish-controller-router/test/unit/deployment-router.bats | Switch deployment/router assertions to go-yq flags throughout. |
| varnish-controller-router/test/unit/deployment-powerdns.bats | Switch deployment/powerdns assertions to go-yq flags throughout. |
| varnish-controller-router/test/unit/configmap-powerdns.bats | Switch ConfigMap powerdns assertions to go-yq flags. |
| varnish-cache/test/unit/statefulset.bats | Switch JSON extraction to go-yq flags for StatefulSet assertions. |
| varnish-cache/test/unit/service.bats | Switch JSON extraction to go-yq flags for Service assertions. |
| varnish-cache/test/unit/pdb.bats | Switch extraction to go-yq flags and update type expectations to !!*. |
| varnish-cache/test/unit/hpa.bats | Switch extraction to go-yq flags and update type expectations to !!int. |
| varnish-cache/test/unit/extra.bats | Switch multi-doc/object filtering to go-yq JSON output. |
| varnish-cache/test/unit/deployment.bats | Switch JSON extraction to go-yq flags for Deployment assertions. |
| varnish-cache/test/unit/daemonset.bats | Switch JSON extraction to go-yq flags for DaemonSet assertions. |
| .github/workflows/ci.yml | Remove python-yq install and tweak unit-test step formatting (CI still needs explicit go-yq install). |
💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.
gquintard
marked this pull request as ready for review
August 18, 2026 13:32
audunmg
approved these changes
Aug 19, 2026
audunmg
left a comment
Collaborator
There was a problem hiding this comment.
Looks clean and tests work well.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
will help with #117