Skip to content

Add CRC32 integrity check for cluster bus messages - #4201

Open
enjoy-binbin wants to merge 3 commits into
valkey-io:unstablefrom
enjoy-binbin:cluster_crc
Open

Add CRC32 integrity check for cluster bus messages#4201
enjoy-binbin wants to merge 3 commits into
valkey-io:unstablefrom
enjoy-binbin:cluster_crc

Revert "handle bot review"

7d482ae
Select commit
Loading
Failed to load commit list.
Codecov / codecov/project succeeded Jul 20, 2026 in 0s

76.80% (-0.01%) compared to 6b006c9

View this Pull Request on Codecov

76.80% (-0.01%) compared to 6b006c9

Details

Codecov Report

❌ Patch coverage is 13.69863% with 63 lines in your changes missing coverage. Please review.
✅ Project coverage is 76.80%. Comparing base (6b006c9) to head (7d482ae).

Files with missing lines Patch % Lines
src/cluster_legacy.c 8.92% 51 Missing ⚠️
src/debug.c 22.22% 7 Missing ⚠️
src/crc32.c 0.00% 5 Missing ⚠️
Additional details and impacted files
@@             Coverage Diff              @@
##           unstable    #4201      +/-   ##
============================================
- Coverage     76.81%   76.80%   -0.01%     
============================================
  Files           162      163       +1     
  Lines         81455    81527      +72     
============================================
+ Hits          62570    62618      +48     
- Misses        18885    18909      +24     
Files with missing lines Coverage Δ
src/cluster.c 92.43% <100.00%> (+<0.01%) ⬆️
src/config.c 79.85% <ø> (ø)
src/server.c 89.46% <100.00%> (-0.05%) ⬇️
src/server.h 100.00% <ø> (ø)
src/crc32.c 0.00% <0.00%> (ø)
src/debug.c 55.52% <22.22%> (-0.26%) ⬇️
src/cluster_legacy.c 86.89% <8.92%> (-1.32%) ⬇️

... and 13 files with indirect coverage changes

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.