Repository navigation
feat: exlude user - #10
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This pull request introduces support for per-folder user exclusions in access control, allowing administrators to specify folders that are accessible to all authenticated users except certain explicitly excluded users. This is achieved by extending the
FOLDER_PERMISSIONSsyntax and updating both the documentation and the entrypoint logic to generate the correct Apache authorization directives. Comprehensive tests and documentation updates are included to demonstrate and verify the new feature.Access control and authorization improvements:
FOLDER_PERMISSIONSusing the!usernamesyntax (e.g.,* !charlie), allowing any authenticated user except specified users to access a folder. This is implemented in thedocker-entrypoint.shby parsing exclusions and generating appropriate<RequireAll>and<RequireNone>blocks in Apache config.403 Forbiddenresponse (not401 Unauthorized), providing clear feedback when access is denied due to exclusion.Documentation and examples:
README.md,.env, anddocs/examples.mdto document the new exclusion syntax, provide usage examples, and clarify the permission model. [1] [2] [3] [4] [5]docs/examples.mddemonstrating user exclusion in a Docker Compose setup.Testing:
docs/tests.mdandtests/scenario-1-basic-auth.shto include dedicated tests for user exclusion, verifying that excluded users are denied access with403while others are allowed. [1] [2] [3]Other documentation updates:
docs/examples.mdto reflect the new exclusion example. [1] [2] [3]