fix: do not validate fullscreen date-picker on internal blur while opening - #12434
Merged
Conversation
vaadin-review-bot
left a comment
vaadin-review-bot
left a comment
There was a problem hiding this comment.
Reviewed the changes — left 2 comments.
| Finding | |
|---|---|
| 🧹 | New __ignoreInternalBlur flag duplicates the picker family's existing _closeOnBlurIsPrevented "internal blur" guard. |
| 👀 | No test chains the flag-setting _onFocus path with a later real validation, so a stuck flag would go unnoticed. |
web-padawan
force-pushed
the
fix/12432-fullscreen-invalid-on-open
branch
from
August 14, 2026 08:07
beac5f3 to
ec5d773
Compare
In fullscreen mode text input is disabled, so focusing the input blurs it again right away to hide the virtual keyboard. That blur is an internal detail, but the blur handler could not tell it apart from a real one and ran the full "user left the field" logic. Tapping a required date-picker therefore marked it invalid while the calendar was still opening, before the user could pick anything. The value commit is skipped along with the validation: in this mode the input cannot be typed into, so there is never a typed value to commit. Fixes #12432 Co-Authored-By: Claude Opus 5 <noreply@anthropic.com>
web-padawan
force-pushed
the
fix/12432-fullscreen-invalid-on-open
branch
from
August 14, 2026 08:09
ec5d773 to
6f298ed
Compare
|
web-padawan
changed the title
sissbruecker
approved these changes
Aug 18, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Fixes #12432
Added the flag around the
blur()call when opening infullscreenmode to not run validation.🤖 Generated with Claude Code