fix: clear row item for loading grid rows - #12000
Draft
vursen wants to merge 5 commits into
Draft
Conversation
vursen
force-pushed
the
fix/grid-clear-loading-row-item
branch
2 times, most recently
from
June 30, 2026 10:10
5769d2c to
1c3f3d6
Compare
vursen
force-pushed
the
fix/grid-clear-loading-row-item
branch
from
June 30, 2026 10:16
f7037cf to
1c3f3d6
Compare
Assign row._item unconditionally in __updateRow so a row in a loading state gets undefined instead of keeping the stale item from its previous position. Reading row._item during loading (selection, keyboard nav, drag-and-drop) no longer acts on the wrong item. Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
Clearing a loading row's item leaves the row without an item while data reloads, so starting an edit on it crashes on a null editor. Skip the affected tests until the edit start is deferred until the item loads. Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
Add tests verifying cell-activate and row-activate carry an undefined item when activating a loading row. Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
vursen
force-pushed
the
fix/grid-clear-loading-row-item
branch
from
June 30, 2026 11:04
1c3f3d6 to
1c6b870
Compare
When committing an edit triggers clearCache(), the next cell's row can still be loading and has no item, so rendering an editor against it crashes on a null editor. Defer the edit and resume it from __updateRow once the item has loaded.
|
vursen
marked this pull request as draft
June 30, 2026 13:36
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
WIP