Skip to content

[LAPACK][cuSOLVER] Fix incorrect QR results on repeated runs (#626) #748

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
zjin-lcf wants to merge 4 commits into
base: develop
Choose a base branch
from
+324 −43
Open

[LAPACK][cuSOLVER] Fix incorrect QR results on repeated runs (#626) #748

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
4c74b52
[LAPACK][cuSOLVER] Fix incorrect QR results on repeated runs
zjin-lcf Jul 28, 2026
ea9c9b9
[LAPACK] Add geqrf+orgqr diagonal regression test for #626
zjin-lcf Aug 10, 2026
1dc8b30
[LAPACK][cuSOLVER] Check devInfo allocation before passing it to cuSO…
zjin-lcf Aug 12, 2026
bd54ae7
[LAPACK][tests] Make orgqr depend on the geqrf event in the QR regres…
zjin-lcf Aug 12, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
10 changes: 10 additions & 0 deletions src/lapack/backends/cusolver/cusolver_helper.hpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -290,6 +290,16 @@ struct CudaEquivalentType<std::complex<double>> {

/* devinfo */

/* Allocates the device memory cuSOLVER writes its `devInfo` output to. A failed
* allocation must not be passed on to cuSOLVER as a null pointer, since that
* silently disables the routine's error reporting. */
inline int* create_devinfo(sycl::queue& queue, const char* func_name, int dev_info_size = 1) {
int* devInfo = sycl::malloc_device<int>(dev_info_size, queue);
if (!devInfo)
throw oneapi::math::device_bad_alloc("lapack", func_name, queue.get_device());
return devInfo;
}

inline void get_cusolver_devinfo(sycl::queue& queue, sycl::buffer<int>& devInfo,
std::vector<int>& dev_info_) {
sycl::host_accessor<int, 1, sycl::access::mode::read> dev_info_acc{ devInfo };
Expand Down
Loading