Skip to content

feat: Devtools - A separate, lightweight event bus -- utilizing Dispatch (Sync) #950

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
theVedanta wants to merge 17 commits into from
Closed

feat: Devtools - A separate, lightweight event bus -- utilizing Dispatch (Sync) #950

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
17 commits
Select commit Hold shift + click to select a range
859468e
observe dispatch (sync)
theVedanta Dec 25, 2025
1cfd7ef
small change in cancel()
theVedanta Dec 25, 2025
5fe505c
terminology -- observe
theVedanta Dec 25, 2025
8dcba1c
Event bus and logger observe() API in effect
theVedanta Dec 28, 2025
0f8cec0
timestamp + abstractions
theVedanta Jan 8, 2026
8a7b56e
Moving logger on client as observer
theVedanta Jan 8, 2026
3cd95e0
removed client id
theVedanta Jan 8, 2026
be0b792
removed event bus & replaced w/ ObserveDispatch
theVedanta Jan 9, 2026
353fcaa
stronger typesafety
theVedanta Jan 17, 2026
a5990bb
logger removed -- client now subscribes with eventBus
theVedanta Jan 17, 2026
d37a487
overlooked errors
theVedanta Jan 20, 2026
cd9a4e2
warning type
theVedanta Feb 7, 2026
75153b1
merge
theVedanta Mar 3, 2026
820a8cc
merge-related changes
theVedanta Mar 9, 2026
b6999f7
more merge changes
theVedanta Mar 30, 2026
c8a2c3f
devtools bus map changed + logger separately added
theVedanta Mar 31, 2026
d89ca14
more merge
theVedanta Mar 31, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
18 changes: 14 additions & 4 deletions dev/index.html
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -155,19 +155,29 @@
}

function setQueryLog() {
vg.coordinator().manager.logQueries(qlogToggle.checked);
const bus = coordinator().eventBus;

bus.observe("query-start", (event) =>
console.info("Query started:", event),
);
bus.observe("query-end", (event) => console.info("Query ended:", event));
bus.observe("client-connect", (event) =>
console.info("Client connected:", event),
);
bus.observe("warning", (event) => console.warn("Warning:", event));
bus.observe("error", (event) => console.error("Error:", event));
}

function setCache() {
vg.coordinator().manager.cache(cacheToggle.checked);
coordinator().manager.cache(cacheToggle.checked);
}

function setConsolidate() {
vg.coordinator().manager.consolidate(consolidateToggle.checked);
coordinator().manager.consolidate(consolidateToggle.checked);
}

function setPreAggregate() {
vg.coordinator().preaggregator.enabled = preaggToggle.checked;
coordinator().preaggregator.enabled = preaggToggle.checked;
}

function reload() {
Expand Down
16 changes: 16 additions & 0 deletions dev/query/index.html
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -73,6 +73,22 @@
}
enable();
});

function setQueryLog() {

@domoritz domoritz Jan 31, 2026

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Shouldn't this logic (which replicates the old logger, right?) be in mosaic core so that people can easily get the old logger behavior again?

@theVedanta theVedanta Feb 1, 2026

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ahh. we can definitely do that. My mistake, I felt that when we said 'remove the logger from core entirely,' we give the client the option to write that logic. I can put this function in core to give back a logger util to the user/client (perhaps we can discuss that idea some more (?))

@domoritz domoritz Feb 4, 2026

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

IIRC the idea was to remove the logger but give users an equivalent tool via the new bus.

const bus = vg.coordinator().eventBus;

bus.observe("query-start", (event) =>
console.info("Query started:", event),
);
bus.observe("query-end", (event) => console.info("Query ended:", event));
bus.observe("client-connect", (event) =>
console.info("Client connected:", event),
);
bus.observe("warning", (event) => console.warn("Warning:", event));
bus.observe("error", (event) => console.error("Error:", event));
}

setQueryLog()
</script>
</body>
</html>
Loading