feat: improve ast-to-dom typing#692
Merged
Merged
Conversation
jheer
approved these changes
Feb 17, 2025
jheer
left a comment
jheer
left a comment
Member
There was a problem hiding this comment.
Thanks, this looks good! However, if not too much hassle it would be great to also add proper types and comments for the InstantiateContext parameters below.
jheer
requested changes
Feb 18, 2025
jheer
left a comment
jheer
left a comment
Member
There was a problem hiding this comment.
Looks good except for the publish package file that snuck in.
rpechuk
force-pushed
the
ron/ast-to-dom-typing
branch
from
February 21, 2025 03:34
433009e to
3943eab
Compare
rpechuk
force-pushed
the
ron/ast-to-dom-typing
branch
from
February 21, 2025 03:37
3943eab to
529c325
Compare
jheer
approved these changes
Feb 28, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Improved the typing of the
optionsparameter ofast-to-domto be based onInstantiateContextas this is what it is being used for.