cp: fix metadata handling on WASI - #13913
Draft
DePasqualeOrg wants to merge 5 commits into
Draft
Conversation
Merging this PR will degrade performance by 7.37%
Warning Please fix the performance issues or acknowledge them on CodSpeed. Performance Changes
Tip Investigate this regression by commenting Comparing Footnotes
|
|
GNU testsuite comparison: |
DePasqualeOrg
force-pushed
the
cp-wasi-file-symlink-timestamps
branch
from
August 13, 2026 13:46
9544b4f to
4b6a382
Compare
DePasqualeOrg
force-pushed
the
cp-wasi-file-symlink-timestamps
branch
from
August 13, 2026 14:15
4b6a382 to
b0fb181
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Correcting
cpmetadata handling on WASI requires extensive changes. I’m offering this as a possible reference implementation. It was developed over multiple rounds of review with Codex, and I don’t claim to fully understand everything. I’ll maintain this as a private patch for my own use until the issues are addressed here.Changes:
--progresstimestamp capture and stale-snapshot checks--updateskip behavior, including recursive copies