Skip to content

uucore: add target_os to systemd_logind cfg check - #13832

Draft
xtqqczze wants to merge 1 commit into
uutils:mainfrom
xtqqczze:feat_systemd_logind
Draft

uucore: add target_os to systemd_logind cfg check#13832
xtqqczze wants to merge 1 commit into
uutils:mainfrom
xtqqczze:feat_systemd_logind

Conversation

@xtqqczze

@xtqqczze xtqqczze commented Aug 9, 2026

Copy link
Copy Markdown
Contributor

One small step toward: cargo check --workspace --all-targets --all-features --target x86_64-pc-windows-gnu

@oech3

oech3 commented Aug 9, 2026

Copy link
Copy Markdown
Contributor

We remove it at #11579 .

@github-actions

github-actions Bot commented Aug 9, 2026

Copy link
Copy Markdown

Binary size comparison:

Individual binary size comparison VS main (threshold: >=5% AND >=4 KB).

Total size of compared binaries: 148.57 MB (+972 KB, +0.64%)

Significant per-binary changes:
  ls         2.11 MB ->    3.25 MB  (+1.14 MB, +54.36%)
  mkfifo     1.16 MB ->    1.08 MB  (-76 KB, -6.42%)
  mknod      1.16 MB ->    1.09 MB  (-76 KB, -6.38%)
  mkdir      1.16 MB ->    1.09 MB  (-72 KB, -6.04%)

@github-actions

github-actions Bot commented Aug 9, 2026

Copy link
Copy Markdown

GNU testsuite comparison:

Skip an intermittent issue tests/cut/bounded-memory (fails in this run but passes in the 'main' branch)
Skip an intermittent issue tests/tail/inotify-dir-recreate (fails in this run but passes in the 'main' branch)
Skipping an intermittent issue tests/tail/symlink (passes in this run but fails in the 'main' branch)

@codspeed-hq

codspeed-hq Bot commented Aug 9, 2026

Copy link
Copy Markdown

Merging this PR will degrade performance by 18.66%

⚠️ Different runtime environments detected

Some benchmarks with significant performance changes were compared across different runtime environments,
which may affect the accuracy of the results.

Open the report in CodSpeed to investigate

❌ 1 regressed benchmark
✅ 346 untouched benchmarks
⏩ 46 skipped benchmarks1

Warning

Please fix the performance issues or acknowledge them on CodSpeed.

Performance Changes

Mode Benchmark BASE HEAD Efficiency
Simulation df_with_path 572.9 µs 704.4 µs -18.66%

Tip

Investigate this regression by commenting @codspeedbot fix this regression on this PR, or directly use the CodSpeed MCP with your agent.


Comparing xtqqczze:feat_systemd_logind (3cf5970) with main (d6d6dc8)

Open in CodSpeed

Footnotes

  1. 46 benchmarks were skipped, so the baseline results were used instead. If they were deleted from the codebase, click here and archive them to remove them from the performance reports.

@xtqqczze
xtqqczze marked this pull request as draft August 9, 2026 19:25
@xtqqczze
xtqqczze force-pushed the feat_systemd_logind branch from ce647a1 to 3cf5970 Compare August 9, 2026 19:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants