date: support european dates and out-of-range years - #13818
Conversation
Merging this PR will degrade performance by 4.1%
|
| Mode | Benchmark | BASE |
HEAD |
Efficiency | |
|---|---|---|---|---|---|
| ❌ | Simulation | du_max_depth_balanced_tree[(6, 4, 10)] |
62 ms | 64.7 ms | -4.14% |
| ❌ | Simulation | du_summarize_balanced_tree[(5, 4, 10)] |
16 ms | 16.6 ms | -4.06% |
Tip
Investigate this regression by commenting @codspeedbot fix this regression on this PR, or directly use the CodSpeed MCP with your agent.
Comparing MuntasirSZN:date-pl (5c25094) with main (2822878)
Footnotes
-
46 benchmarks were skipped, so the baseline results were used instead. If they were deleted from the codebase, click here and archive them to remove them from the performance reports. ↩
|
GNU testsuite comparison: |
|
These tests are copied from GNU coreutils and should be licensed as such. |
Ok I gave attribution |
As per CONTRIBUTING.md, we cannot accept any changes based on the GNU source code. I recommend closing this PR and starting again from scratch. |
|
yeah, you need to rewrite the tests |
Ok doing it.... |
|
Binary size comparison: |
c918fea to
e991362
Compare
|
@sylvestre @collinfunk @xtqqczze Sorry for ping, can you guys check now? |
|
@MuntasirSZN Could you please confirm that no code in this PR has been derived from GNU coreutils or any other GPL-licensed source, including small snippets, helper structures, test fixtures, or comments? If you used an AI assistant during development, please also verify its output carefully, as AI-generated code may reproduce material from GPL-licensed sources, potentially without making the provenance apparent. |
No, @xtqqczze. I verified myself. |
`date` accepts DAY.MONTH[.YEAR] dates (yearless forms use the current year) and years beyond 9999 with any format. uutils rejected both, failing parts of tests/date/date.pl. Rewrite european dates to ISO before parsing; accept extended years for all output formats. Adds unit and integration tests. Signed-off-by: MuntasirSZN <muntasir.joypurhat@gmail.com
|
@sylvestre @cakebaker review pls? Sorry for ping. |
dateacceptsDAY.MONTH[.YEAR]dates (yearless forms use the currentyear) and years beyond 9999 with any format. uutils/coreutils rejected both,
failing parts of tests/date/date.pl.
Rewrite european dates to ISO before parsing; accept extended years for
all output formats. Adds unit and integration tests.
tests/date/date.pl gnu test now passes.
Signed-off-by: MuntasirSZN muntasir.joypurhat@gmail.com