mkfifo: fix build where mode_t is not u32 - #13775
Open
pkubaj wants to merge 1 commit into
Open
Conversation
oech3
reviewed
Aug 6, 2026
Merging this PR will improve performance by 22.81%
|
| Mode | Benchmark | BASE |
HEAD |
Efficiency | |
|---|---|---|---|---|---|
| ⚡ | Simulation | df_with_path |
704.6 µs | 573.7 µs | +22.81% |
Tip
Curious why this is faster? Comment @codspeedbot explain why this is faster on this PR, or directly use the CodSpeed MCP with your agent.
Comparing pkubaj:patch-1 (959d6e0) with main (98dd261)
Footnotes
-
46 benchmarks were skipped, so the baseline results were used instead. If they were deleted from the codebase, click here and archive them to remove them from the performance reports. ↩
pkubaj
force-pushed
the
patch-1
branch
2 times, most recently
from
August 6, 2026 12:30
39ba52d to
192e71b
Compare
Contributor
|
on which bsd? thanks |
Contributor
Author
|
FreeBSD. |
oech3
reviewed
Aug 6, 2026
|
GNU testsuite comparison: |
`rustix::fs::Mode` is a bitflags over `rustix::fs::RawMode`, which aliases
`libc::mode_t`. That is `u32` on Linux but `u16` on the BSDs, so handing the
`u32` mode straight to `Mode::from_bits_truncate()` fails to compile there:
error[E0308]: mismatched types
| fs::mkfifoat(fs::CWD, path, Mode::from_bits_truncate(mode))
| ------------------------ ^^^^
| expected `u16`, found `u32`
Type `create_fifo` in terms of `RawMode` so the conversion happens once at the
call site, where the parsed `u32` becomes a platform mode. The cast is a no-op
on Linux, matching what `mkdir` already does in src/uu/mkdir/src/mkdir.rs. The
Apple arm keeps its explicit `as libc::mode_t`: `RawMode` is defined as
`c::mode_t` so the cast is an identity there, but keeping it compiles either way
and that arm cannot be exercised by CI on Linux.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
rustix::fs::Modeis a bitflags overrustix::fs::RawMode, which aliaseslibc::mode_t. That isu32on Linux butu16on the BSDs, so handing theu32mode straight toMode::from_bits_truncate()fails to compile there:Cast to
RawModefirst, which is a no-op on Linux and matches whatmkdiralready does in src/uu/mkdir/src/mkdir.rs.