Conversation
The post step ANDed vmHydratedGitMirror with shouldCommit before sending it to the host, so a job whose initial clone succeeded but that could not commit (failed job, throttled commit, sync failure) was indistinguishable from a job whose clone failed. The host already combines the raw flag with shouldCommit to decide whether hydration was persisted, and only reports the persisted result to the backend; the raw flag is what lets it label the outcome hydrated-not-persisted instead of clone-failed. Send performedHydration as-is from main.ts and stop clearing it in cleanup() on sync/unmount failure; shouldCommit is still forced false there. Co-Authored-By: Devin AI <158243242+devin-ai-integration[bot]@users.noreply.github.com>
Contributor
|
I'll fix CI failures and address comments from users with write access. I'll skip comments containing "(aside)".
|
piob-io
marked this pull request as ready for review
September 18, 2026 23:35
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
The host classifies a git-mirror hydration as
completed/hydrated-not-persisted/clone-failedfrom two flags the post step sends incommitStickyDisk:shouldCommitandvmHydratedGitMirror. We were pre-ANDing them on the action side:so a job whose initial clone succeeded but that could not commit (failed job, throttled/denied commit, sync failure) reached the host as
vmHydrated=falseand was stampedclone-failed— thehydrated-not-persistedbucket on the hydration funnel was unreachable, and successful clones were being counted as clone failures.cleanup()likewise stops clearing the flag when the sync fails/times out or the unmount fails; it still forcesshouldCommit=falsein those paths.Backend safety: the host has computed
hydrationPersisted := shouldCommit && VMHydratedGitMirrorand sent that to the backend since FastActions/fa#3218 (March), which every deployed agent tag includes — so the backend never sees a rawtruefor an uncommitted disk; only the outcome label changes.Tests: sync-failure/timeout cases now assert
{shouldCommit: false, vmHydratedGitMirror: true}; new case forshouldCommit=falsewith a performed hydration (no maintenance, flag passed through).dist/index.jsrebuilt.Link to Devin session: https://app.devin.ai/sessions/53ae2d32138144f4832eae008103aa71
Open in Devin Desktop: https://app.devin.ai/desktop/session/53ae2d32138144f4832eae008103aa71?variant=devin
Requested by: @piob-io
Need help on this PR? Tag
@codesmith-botwith what you need. Autofix is disabled.View with [code]smith Autofix with [code]smith
Need help on this PR? Tag
@codesmith-botwith what you need. Autofix is disabled. (Staging)